From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [RFC v2 0/4] adding mdev bus and vfio support Date: Fri, 2 Sep 2016 09:03:52 -0600 Message-ID: <20160902090352.53afdab1@t450s.home> References: <1472804172-25542-1-git-send-email-jike.song@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kwankhede@nvidia.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, bjsdjshi@linux.vnet.ibm.com, kevin.tian@intel.com, guangrong.xiao@linux.intel.com, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, pbonzini@redhat.com, kraxel@redhat.com To: Jike Song Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48714 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbcIBPDy (ORCPT ); Fri, 2 Sep 2016 11:03:54 -0400 In-Reply-To: <1472804172-25542-1-git-send-email-jike.song@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2 Sep 2016 16:16:08 +0800 Jike Song wrote: > This patchset is based on NVidia's "Add Mediated device support" series, version 6: > > http://www.spinics.net/lists/kvm/msg136472.html Hi Jike, I'm thrilled by your active participation here, but I'm confused which versions I should be reviewing and where the primary development is going. Kirti sent v7 a week ago, so I would have expected a revision based on that rather than a re-write based on v6 plus incorporation of a few of Kirti's patches directly. I liked the last version of these changes a lot, but we need to figure out how to combine development because we do not have infinite cycles for review available :-\ Thanks! Alex > > > Key Changes from Nvidia v6: > > - Introduced an independent struct device to host device, thereby > formed a physical-host-mdev hierarchy, and highly reused Linux > driver core support; > > - Added online/offline to mdev_bus_type, leveraging the 'online' > attr support from Linux driver core; > > - Removed mdev_class and other unecessary stuff; > > /* > * Given the changes above, the code volume of mdev core driver > * dramatically reduced by ~50%. > */ > > > - Interfaces between vfio_mdev and vendor driver are high-level, > e.g. ioctl instead of get_irq_info/set_irq_info and reset, > start/stop became mdev oriented, etc.; > > /* > * Given the changes above, the code volume of mdev core driver > * dramatically reduced by ~64%. > */ > > > Test > > - Tested with KVMGT > > TODO > > - Re-implement the attribute group of host device as long as the > sysfs hierarchy in discussion gets finalized; > > - Move common routines from current vfio-pci into a higher location, > export them for various VFIO bus drivers and/or mdev vendor drivers; > > - Add implementation examples for vendor drivers to Documentation; > > - Refine IOMMU changes > > > > Jike Song (2): > Mediated device Core driver > vfio: VFIO bus driver for MDEV devices > > Kirti Wankhede (2): > vfio iommu: Add support for mediated devices > docs: Add Documentation for Mediated devices > > Documentation/vfio-mediated-device.txt | 203 ++++++++++++++ > drivers/vfio/Kconfig | 1 + > drivers/vfio/Makefile | 1 + > drivers/vfio/mdev/Kconfig | 18 ++ > drivers/vfio/mdev/Makefile | 5 + > drivers/vfio/mdev/mdev_core.c | 250 +++++++++++++++++ > drivers/vfio/mdev/mdev_driver.c | 155 ++++++++++ > drivers/vfio/mdev/mdev_private.h | 29 ++ > drivers/vfio/mdev/mdev_sysfs.c | 155 ++++++++++ > drivers/vfio/mdev/vfio_mdev.c | 187 ++++++++++++ > drivers/vfio/vfio.c | 82 ++++++ > drivers/vfio/vfio_iommu_type1.c | 499 +++++++++++++++++++++++++++++---- > include/linux/mdev.h | 159 +++++++++++ > include/linux/vfio.h | 13 +- > 14 files changed, 1709 insertions(+), 48 deletions(-) > create mode 100644 Documentation/vfio-mediated-device.txt > create mode 100644 drivers/vfio/mdev/Kconfig > create mode 100644 drivers/vfio/mdev/Makefile > create mode 100644 drivers/vfio/mdev/mdev_core.c > create mode 100644 drivers/vfio/mdev/mdev_driver.c > create mode 100644 drivers/vfio/mdev/mdev_private.h > create mode 100644 drivers/vfio/mdev/mdev_sysfs.c > create mode 100644 drivers/vfio/mdev/vfio_mdev.c > create mode 100644 include/linux/mdev.h > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfq0d-0004Lh-PC for qemu-devel@nongnu.org; Fri, 02 Sep 2016 11:04:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfq0Y-0006Za-Lb for qemu-devel@nongnu.org; Fri, 02 Sep 2016 11:03:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfq0Y-0006ZW-Dr for qemu-devel@nongnu.org; Fri, 02 Sep 2016 11:03:54 -0400 Date: Fri, 2 Sep 2016 09:03:52 -0600 From: Alex Williamson Message-ID: <20160902090352.53afdab1@t450s.home> In-Reply-To: <1472804172-25542-1-git-send-email-jike.song@intel.com> References: <1472804172-25542-1-git-send-email-jike.song@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 0/4] adding mdev bus and vfio support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jike Song Cc: kwankhede@nvidia.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, bjsdjshi@linux.vnet.ibm.com, kevin.tian@intel.com, guangrong.xiao@linux.intel.com, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, pbonzini@redhat.com, kraxel@redhat.com On Fri, 2 Sep 2016 16:16:08 +0800 Jike Song wrote: > This patchset is based on NVidia's "Add Mediated device support" series, version 6: > > http://www.spinics.net/lists/kvm/msg136472.html Hi Jike, I'm thrilled by your active participation here, but I'm confused which versions I should be reviewing and where the primary development is going. Kirti sent v7 a week ago, so I would have expected a revision based on that rather than a re-write based on v6 plus incorporation of a few of Kirti's patches directly. I liked the last version of these changes a lot, but we need to figure out how to combine development because we do not have infinite cycles for review available :-\ Thanks! Alex > > > Key Changes from Nvidia v6: > > - Introduced an independent struct device to host device, thereby > formed a physical-host-mdev hierarchy, and highly reused Linux > driver core support; > > - Added online/offline to mdev_bus_type, leveraging the 'online' > attr support from Linux driver core; > > - Removed mdev_class and other unecessary stuff; > > /* > * Given the changes above, the code volume of mdev core driver > * dramatically reduced by ~50%. > */ > > > - Interfaces between vfio_mdev and vendor driver are high-level, > e.g. ioctl instead of get_irq_info/set_irq_info and reset, > start/stop became mdev oriented, etc.; > > /* > * Given the changes above, the code volume of mdev core driver > * dramatically reduced by ~64%. > */ > > > Test > > - Tested with KVMGT > > TODO > > - Re-implement the attribute group of host device as long as the > sysfs hierarchy in discussion gets finalized; > > - Move common routines from current vfio-pci into a higher location, > export them for various VFIO bus drivers and/or mdev vendor drivers; > > - Add implementation examples for vendor drivers to Documentation; > > - Refine IOMMU changes > > > > Jike Song (2): > Mediated device Core driver > vfio: VFIO bus driver for MDEV devices > > Kirti Wankhede (2): > vfio iommu: Add support for mediated devices > docs: Add Documentation for Mediated devices > > Documentation/vfio-mediated-device.txt | 203 ++++++++++++++ > drivers/vfio/Kconfig | 1 + > drivers/vfio/Makefile | 1 + > drivers/vfio/mdev/Kconfig | 18 ++ > drivers/vfio/mdev/Makefile | 5 + > drivers/vfio/mdev/mdev_core.c | 250 +++++++++++++++++ > drivers/vfio/mdev/mdev_driver.c | 155 ++++++++++ > drivers/vfio/mdev/mdev_private.h | 29 ++ > drivers/vfio/mdev/mdev_sysfs.c | 155 ++++++++++ > drivers/vfio/mdev/vfio_mdev.c | 187 ++++++++++++ > drivers/vfio/vfio.c | 82 ++++++ > drivers/vfio/vfio_iommu_type1.c | 499 +++++++++++++++++++++++++++++---- > include/linux/mdev.h | 159 +++++++++++ > include/linux/vfio.h | 13 +- > 14 files changed, 1709 insertions(+), 48 deletions(-) > create mode 100644 Documentation/vfio-mediated-device.txt > create mode 100644 drivers/vfio/mdev/Kconfig > create mode 100644 drivers/vfio/mdev/Makefile > create mode 100644 drivers/vfio/mdev/mdev_core.c > create mode 100644 drivers/vfio/mdev/mdev_driver.c > create mode 100644 drivers/vfio/mdev/mdev_private.h > create mode 100644 drivers/vfio/mdev/mdev_sysfs.c > create mode 100644 drivers/vfio/mdev/vfio_mdev.c > create mode 100644 include/linux/mdev.h >