From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 08/17] drm/i915: Drop spinlocks around adding to the client request list Date: Fri, 2 Sep 2016 11:59:12 +0100 Message-ID: <20160902105912.GG6358@nuc-i3427.alporthouse.com> References: <20160822080350.4964-1-chris@chris-wilson.co.uk> <20160822080350.4964-9-chris@chris-wilson.co.uk> <898ae464-4b9e-2764-9fc6-3513766f7982@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0620A6EA5F for ; Fri, 2 Sep 2016 10:59:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <898ae464-4b9e-2764-9fc6-3513766f7982@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMDIsIDIwMTYgYXQgMTE6MzA6MThBTSArMDEwMCwgSm9obiBIYXJyaXNvbiB3 cm90ZToKPiBPbiAyMi8wOC8yMDE2IDA5OjAzLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPkFkZGlu ZyB0byB0aGUgdGFpbCBvZiB0aGUgY2xpZW50IHJlcXVlc3QgbGlzdCBhcyB0aGUgb25seSBvdGhl ciB1c2VyIGlzCj4gPmluIHRoZSB0aHJvdHRsZSBpb2N0bCB0aGF0IGl0ZXJhdGVzIGZvcndhcmRz IG92ZXIgdGhlIGxpc3QuIEl0IG9ubHkKPiA+bmVlZHMgcHJvdGVjdGlvbiBhZ2FpbnN0IGRlbGV0 aW9uIG9mIGEgcmVxdWVzdCBhcyBpdCByZWFkcyBpdCwgaXQgc2ltcGx5Cj4gPndvbid0IHNlZSBh IG5ldyByZXF1ZXN0IGFkZGVkIHRvIHRoZSBlbmQgb2YgdGhlIGxpc3QsIG9yIGl0IHdvdWxkIGJl IHRvbwo+ID5lYXJseSBhbmQgcmVqZWN0ZWQuIFdlIGNhbiBmdXJ0aGVyIHJlZHVjZSB0aGUgbnVt YmVyIG9mIHNwaW5sb2Nrcwo+ID5yZXF1aXJlZCB3aGVuIHRocm90dGxpbmcgYnkgcmVtb3Zpbmcg c3RhbGUgcmVxdWVzdHMgZnJvbSB0aGUgY2xpZW50X2xpc3QKPiA+YXMgd2UgdGhyb3R0bGUuCj4g Pgo+ID5TaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiA+LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAg IHwgIDIgKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgICAg fCAxNCArKysrKystLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVj YnVmZmVyLmMgfCAxNCArKysrKysrLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9yZXF1ZXN0LmMgICAgfCAzNCArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmggICAgfCAgNCArLS0tCj4g PiAgNSBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA0NSBkZWxldGlvbnMoLSkKPiA+ Cj4gPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPmluZGV4IDA4NjA1M2ZhMjgyMC4u OTk2NzQ0NzA4ZjMxIDEwMDY0NAo+ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+ID4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ID5A QCAtNDgwLDcgKzQ4MCw3IEBAIHN0YXRpYyBpbnQgaTkxNV9nZW1fb2JqZWN0X2luZm8oc3RydWN0 IHNlcV9maWxlICptLCB2b2lkKiBkYXRhKQo+ID4gIAkJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3Rf bXV0ZXgpOwo+ID4gIAkJcmVxdWVzdCA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmZmlsZV9w cml2LT5tbS5yZXF1ZXN0X2xpc3QsCj4gPiAgCQkJCQkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0LAo+ID4tCQkJCQkJICAgY2xpZW50X2xpc3QpOwo+ID4rCQkJCQkJICAgY2xpZW50X2xp bmspOwo+ID4gIAkJcmN1X3JlYWRfbG9jaygpOwo+ID4gIAkJdGFzayA9IHBpZF90YXNrKHJlcXVl c3QgJiYgcmVxdWVzdC0+Y3R4LT5waWQgPwo+ID4gIAkJCQlyZXF1ZXN0LT5jdHgtPnBpZCA6IGZp bGUtPnBpZCwKPiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPmluZGV4IDdiOGFiZGE1NDFlNi4u ZTQzMjIxMWU4YjI0IDEwMDY0NAo+ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+QEAgLTM2NzMs MTYgKzM2NzMsMTQgQEAgaTkxNV9nZW1fcmluZ190aHJvdHRsZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gPiAgCQlyZXR1cm4gLUVJTzsKPiA+ICAJc3Bp bl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+ID4tCWxpc3RfZm9yX2VhY2hfZW50cnkocmVx dWVzdCwgJmZpbGVfcHJpdi0+bW0ucmVxdWVzdF9saXN0LCBjbGllbnRfbGlzdCkgewo+ID4rCWxp c3RfZm9yX2VhY2hfZW50cnkocmVxdWVzdCwgJmZpbGVfcHJpdi0+bW0ucmVxdWVzdF9saXN0LCBj bGllbnRfbGluaykgewo+ID4gIAkJaWYgKHRpbWVfYWZ0ZXJfZXEocmVxdWVzdC0+ZW1pdHRlZF9q aWZmaWVzLCByZWNlbnRfZW5vdWdoKSkKPiA+ICAJCQlicmVhazsKPiA+LQkJLyoKPiA+LQkJICog Tm90ZSB0aGF0IHRoZSByZXF1ZXN0IG1pZ2h0IG5vdCBoYXZlIGJlZW4gc3VibWl0dGVkIHlldC4K PiA+LQkJICogSW4gd2hpY2ggY2FzZSBlbWl0dGVkX2ppZmZpZXMgd2lsbCBiZSB6ZXJvLgo+ID4t CQkgKi8KPiA+LQkJaWYgKCFyZXF1ZXN0LT5lbWl0dGVkX2ppZmZpZXMpCj4gPi0JCQljb250aW51 ZTsKPiA+KwkJaWYgKHRhcmdldCkgewo+ID4rCQkJbGlzdF9kZWwoJnRhcmdldC0+Y2xpZW50X2xp bmspOwo+ID4rCQkJdGFyZ2V0LT5maWxlX3ByaXYgPSBOVUxMOwo+ID4rCQl9Cj4gPiAgCQl0YXJn ZXQgPSByZXF1ZXN0Owo+ID4gIAl9Cj4gPkBAIC00NjM5LDcgKzQ2MzcsNyBAQCB2b2lkIGk5MTVf Z2VtX3JlbGVhc2Uoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9maWxlICpmaWxl KQo+ID4gIAkgKiBmaWxlX3ByaXYuCj4gPiAgCSAqLwo+ID4gIAlzcGluX2xvY2soJmZpbGVfcHJp di0+bW0ubG9jayk7Cj4gPi0JbGlzdF9mb3JfZWFjaF9lbnRyeShyZXF1ZXN0LCAmZmlsZV9wcml2 LT5tbS5yZXF1ZXN0X2xpc3QsIGNsaWVudF9saXN0KQo+ID4rCWxpc3RfZm9yX2VhY2hfZW50cnko cmVxdWVzdCwgJmZpbGVfcHJpdi0+bW0ucmVxdWVzdF9saXN0LCBjbGllbnRfbGluaykKPiA+ICAJ CXJlcXVlc3QtPmZpbGVfcHJpdiA9IE5VTEw7Cj4gPiAgCXNwaW5fdW5sb2NrKCZmaWxlX3ByaXYt Pm1tLmxvY2spOwo+ID5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f ZXhlY2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5j Cj4gPmluZGV4IDEyNWZiMzhlZmY0MC4uNTY4OTQ0NWIxY2QzIDEwMDY0NAo+ID4tLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiA+KysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gPkBAIC0xNDIxLDYgKzE0MjEsMTQg QEAgb3V0Ogo+ID4gIAlyZXR1cm4gdm1hOwo+ID4gIH0KPiA+K3N0YXRpYyB2b2lkCj4gPithZGRf dG9fY2xpZW50KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ID4rCSAgICAgIHN0 cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiA+K3sKPiA+KwlyZXEtPmZpbGVfcHJpdiA9IGZpbGUtPmRy aXZlcl9wcml2Owo+ID4rCWxpc3RfYWRkX3RhaWwoJnJlcS0+Y2xpZW50X2xpbmssICZyZXEtPmZp bGVfcHJpdi0+bW0ucmVxdWVzdF9saXN0KTsKPiA+K30KPiA+Kwo+ID4gIHN0YXRpYyBpbnQKPiA+ ICBleGVjYnVmX3N1Ym1pdChzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3BhcmFtcyAqcGFyYW1zLAo+ ID4gIAkgICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9leGVjYnVmZmVyMiAqYXJncywKPiA+QEAg LTE1MTIsNiArMTUyMCw3IEBAIGV4ZWNidWZfc3VibWl0KHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJf cGFyYW1zICpwYXJhbXMsCj4gPiAgCXRyYWNlX2k5MTVfZ2VtX3JpbmdfZGlzcGF0Y2gocGFyYW1z LT5yZXF1ZXN0LCBwYXJhbXMtPmRpc3BhdGNoX2ZsYWdzKTsKPiA+ICAJaTkxNV9nZW1fZXhlY2J1 ZmZlcl9tb3ZlX3RvX2FjdGl2ZSh2bWFzLCBwYXJhbXMtPnJlcXVlc3QpOwo+ID4rCWFkZF90b19j bGllbnQocGFyYW1zLT5yZXF1ZXN0LCBwYXJhbXMtPmZpbGUpOwo+ID4gIAlyZXR1cm4gMDsKPiA+ ICB9Cj4gPkBAIC0xODA4LDEwICsxODE3LDYgQEAgaTkxNV9nZW1fZG9fZXhlY2J1ZmZlcihzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ID4gIAkgKi8KPiA+ICAJcGFyYW1zLT5y ZXF1ZXN0LT5iYXRjaCA9IHBhcmFtcy0+YmF0Y2g7Cj4gPi0JcmV0ID0gaTkxNV9nZW1fcmVxdWVz dF9hZGRfdG9fY2xpZW50KHBhcmFtcy0+cmVxdWVzdCwgZmlsZSk7Cj4gPi0JaWYgKHJldCkKPiA+ LQkJZ290byBlcnJfcmVxdWVzdDsKPiA+LQo+ID4gIAkvKgo+ID4gIAkgKiBTYXZlIGFzc29ydGVk IHN0dWZmIGF3YXkgdG8gcGFzcyB0aHJvdWdoIHRvICpfc3VibWlzc2lvbigpLgo+ID4gIAkgKiBO QjogVGhpcyBkYXRhIHNob3VsZCBiZSAncGVyc2lzdGVudCcgYW5kIG5vdCBsb2NhbCBhcyBpdCB3 aWxsCj4gPkBAIC0xODI1LDcgKzE4MzAsNiBAQCBpOTE1X2dlbV9kb19leGVjYnVmZmVyKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gPiAgCXBhcmFtcy0+Y3R4ICAgICAgICAg ICAgICAgICAgICAgPSBjdHg7Cj4gPiAgCXJldCA9IGV4ZWNidWZfc3VibWl0KHBhcmFtcywgYXJn cywgJmViLT52bWFzKTsKPiA+LWVycl9yZXF1ZXN0Ogo+ID4gIAlfX2k5MTVfYWRkX3JlcXVlc3Qo cGFyYW1zLT5yZXF1ZXN0LCByZXQgPT0gMCk7Cj4gPiAgZXJyX2JhdGNoX3VucGluOgo+ID5kaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gPmluZGV4IDFhMjE1MzIwY2VmYi4u YmY2MjQyN2EzNWI3IDEwMDY0NAo+ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9yZXF1ZXN0LmMKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVz dC5jCj4gPkBAIC0xMTUsNDIgKzExNSwyMCBAQCBjb25zdCBzdHJ1Y3QgZmVuY2Vfb3BzIGk5MTVf ZmVuY2Vfb3BzID0gewo+ID4gIAkudGltZWxpbmVfdmFsdWVfc3RyID0gaTkxNV9mZW5jZV90aW1l bGluZV92YWx1ZV9zdHIsCj4gPiAgfTsKPiA+LWludCBpOTE1X2dlbV9yZXF1ZXN0X2FkZF90b19j bGllbnQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gPi0JCQkJICAgc3RydWN0 IGRybV9maWxlICpmaWxlKQo+ID4tewo+ID4tCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdmF0ZTsKPiA+LQlzdHJ1Y3QgZHJtX2k5MTVfZmlsZV9wcml2YXRlICpmaWxlX3ByaXY7Cj4g Pi0KPiA+LQlXQVJOX09OKCFyZXEgfHwgIWZpbGUgfHwgcmVxLT5maWxlX3ByaXYpOwo+ID4tCj4g Pi0JaWYgKCFyZXEgfHwgIWZpbGUpCj4gPi0JCXJldHVybiAtRUlOVkFMOwo+ID4tCj4gPi0JaWYg KHJlcS0+ZmlsZV9wcml2KQo+ID4tCQlyZXR1cm4gLUVJTlZBTDsKPiA+LQo+ID4tCWRldl9wcml2 YXRlID0gcmVxLT5pOTE1Owo+ID4tCWZpbGVfcHJpdiA9IGZpbGUtPmRyaXZlcl9wcml2Owo+ID4t Cj4gPi0Jc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+ID4tCXJlcS0+ZmlsZV9wcml2 ID0gZmlsZV9wcml2Owo+ID4tCWxpc3RfYWRkX3RhaWwoJnJlcS0+Y2xpZW50X2xpc3QsICZmaWxl X3ByaXYtPm1tLnJlcXVlc3RfbGlzdCk7Cj4gPi0Jc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0u bG9jayk7Cj4gPi0KPiA+LQlyZXR1cm4gMDsKPiA+LX0KPiA+LQo+ID4gIHN0YXRpYyBpbmxpbmUg dm9pZAo+ID4gIGk5MTVfZ2VtX3JlcXVlc3RfcmVtb3ZlX2Zyb21fY2xpZW50KHN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiA+ICB7Cj4gPi0Jc3RydWN0IGRybV9pOTE1X2Zp bGVfcHJpdmF0ZSAqZmlsZV9wcml2ID0gcmVxdWVzdC0+ZmlsZV9wcml2Owo+ID4rCXN0cnVjdCBk cm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdjsKPiA+KwlmaWxlX3ByaXYgPSByZXF1ZXN0 LT5maWxlX3ByaXY7Cj4gPiAgCWlmICghZmlsZV9wcml2KQo+ID4gIAkJcmV0dXJuOwo+ID4gIAlz cGluX2xvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gPi0JbGlzdF9kZWwoJnJlcXVlc3QtPmNs aWVudF9saXN0KTsKPiA+LQlyZXF1ZXN0LT5maWxlX3ByaXYgPSBOVUxMOwo+ID4rCWlmIChyZXF1 ZXN0LT5maWxlX3ByaXYpIHsKPiBXaHkgY2hlY2sgZm9yIHJlcXVlc3QtPmZpbGVfcHJpdiBhZ2Fp bj8gVGhlIGJsb2NrIGFib3ZlIHdpbGwgZXhpdCBpZgo+IGl0IGlzIG51bGwuIFRoZXJlIHN1cmVs eSBjYW4ndCBiZSBhIHJhY2Ugd2l0aCByZW1vdmVfZnJvbV9jbGllbnQKPiBiZWluZyBjYWxsZWQg Y29uY3VycmVudGx5IHdpdGggYWRkX3RvX2NsaWVudD8gRXNwZWNpYWxseSBhcwo+IGFkZF90b19j bGllbnQgbm8gbG9uZ2VyIHRha2VzIHRoZSBzcGluX2xvY2sgYW55d2F5LgoKV2UgY2FuIGhvd2V2 ZXIgYWxsb3cgaTkxNV9nZW1fcmVsZWFzZSgpIHRvIGJlIGNhbGxlZCBjb25jdXJyZW50bHkuIEl0 CmRvZXNuJ3QgcmVxdWlyZSBzdHJ1Y3RfbXV0ZXguCi1DaHJpcwoKLS0gCkNocmlzIFdpbHNvbiwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==