All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional
Date: Fri, 2 Sep 2016 19:19:20 +0200	[thread overview]
Message-ID: <20160902171920.GP16864@lunn.ch> (raw)
In-Reply-To: <87vayens26.fsf@ketchup.mtl.sfl>

> I agree. Does the following snippet looks OK?
> 
> 
>     #ifndef CONFIG_NET_DSA_MV88E6XXX_GLOBAL2
>             if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) {
>                     dev_err(chip->dev, "Missing support for Global 2 registers\n");

I would include the name of the option which needs enabling. Also it
is not really missing. It has not been enabled.

"The required compile time options needed to support this switch have
not been enabled. Please enable: CONFIG_NET_DSA_MV88E6XXX_GLOBAL2"

  Andrew

  reply	other threads:[~2016-09-02 17:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 12:08 [PATCH net-next 0/3] net: dsa: mv88e6xxx: isolate Global2 support Vivien Didelot
2016-09-02 12:08 ` [PATCH net-next 1/3] net: dsa: mv88e6xxx: fix module naming Vivien Didelot
2016-09-02 12:08 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: move Global2 code Vivien Didelot
2016-09-02 12:08 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional Vivien Didelot
2016-09-02 14:55   ` Andrew Lunn
2016-09-02 15:22     ` Vivien Didelot
2016-09-02 16:11       ` Andrew Lunn
2016-09-02 17:13         ` Vivien Didelot
2016-09-02 17:19           ` Andrew Lunn [this message]
2016-09-02 17:32             ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160902171920.GP16864@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.