From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfsvj-0006ha-5k for qemu-devel@nongnu.org; Fri, 02 Sep 2016 14:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfsve-0006C4-VK for qemu-devel@nongnu.org; Fri, 02 Sep 2016 14:11:06 -0400 Date: Fri, 2 Sep 2016 15:10:55 -0300 From: Eduardo Habkost Message-ID: <20160902181055.GK1151@thinpad.lan.raisama.net> References: <1472674630-18886-1-git-send-email-ehabkost@redhat.com> <20160831214625.373180.83128@ex-std-node742.prod.rhcloud.com> <20160901151030.GC1151@thinpad.lan.raisama.net> <27ce8661-7e37-9533-cbee-6a0e6daeb165@redhat.com> <20160901173937.GE1151@thinpad.lan.raisama.net> <20160901193445.GF1151@thinpad.lan.raisama.net> <20160902140430.GI1151@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] vl: Delay initialization of memory backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, famz@redhat.com, mprivozn@redhat.com, bsd@redhat.com, qemu-stable@nongnu.org, Yang Hongyang , Jason Wang On Fri, Sep 02, 2016 at 04:56:49PM +0200, Paolo Bonzini wrote: > On 02/09/2016 16:04, Eduardo Habkost wrote: [...] > > Now, why exactly vhost-user-test needs accel=tcg and can't use > > accel=qtest? > > Because it uses iPXE to exercise the NIC. Is it used to actually exercise the NIC, or just to initialize it? Original commit says "pc-bios/pxe-virtio.rom is used to instantiate a virtio pcicontroller". I don't see any test code that receives any data from iPXE: nothing is read from log_fd, the VHOST_USER_SET_VRING_KICK/VHOST_USER_SET_VRING_CALL FDs are simply ignored. The only memory writes/reads are on the first memory page. I suggest simply using libqos. If somebody really wants rx/tx tests using vhost-user, they can be written using libqos (just like virtio-net-test.c). -- Eduardo