From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbcICANH (ORCPT ); Fri, 2 Sep 2016 20:13:07 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:35408 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbcICANG (ORCPT ); Fri, 2 Sep 2016 20:13:06 -0400 Date: Sat, 3 Sep 2016 01:13:01 +0100 From: Al Viro To: Oleg Nesterov Cc: Dmitry Safonov , linux-kernel@vger.kernel.org, mingo@redhat.com, luto@amacapital.net, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, 0x7f454c46@gmail.com, rostedt@goodmis.org Subject: Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping Message-ID: <20160903001301.GZ2356@ZenIV.linux.org.uk> References: <20160825152110.25663-1-dsafonov@virtuozzo.com> <20160825152110.25663-2-dsafonov@virtuozzo.com> <20160830143311.GA23007@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160830143311.GA23007@redhat.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 04:33:12PM +0200, Oleg Nesterov wrote: > > + inode = ramfs_get_inode(sb, NULL, S_IFREG | S_IRUGO | S_IXUGO, 0); > Not sure... I think alloc_anon_inode() makes more sense. Compared to this, you mean? It's going to give you the wrong permissions/i_op/a_ops, and you'll have to assign them manually. ramfs already gives the right ones for what's wanted, AFAICS.