From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] admin-cmd: Added smart-log command support.
Date: Mon, 5 Sep 2016 06:11:27 -0700 [thread overview]
Message-ID: <20160905131127.GA3176@infradead.org> (raw)
In-Reply-To: <ac203b28-39ed-4f2a-b0fc-f586e43c9346@grimberg.me>
On Sun, Sep 04, 2016@11:41:09AM +0300, Sagi Grimberg wrote:
> Given that we don't own the namespaces, I'm wandering if this is the
> correct way to do this... I'm not at all convinced that having something
> else reading/writing to the blkdevs other than nvmf is a valid/useful
> use-case but in this situation we won't get correct log information
> (or at least the semantics is wrong).
>
> Should we maintain these statistics in the target stack instead?
What's the problem with including possible local I/O? Having to
maintain another set of counters, including atomics in the fast path
or complex per-cpu infrastructure is something I'd rather avoid.
next prev parent reply other threads:[~2016-09-05 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 19:45 [PATCH] admin-cmd: Added smart-log command support Chaitanya Kulkarni
2016-09-04 8:41 ` Sagi Grimberg
2016-09-05 13:11 ` Christoph Hellwig [this message]
2016-09-05 14:09 ` Sagi Grimberg
2016-09-20 19:00 ` Sagi Grimberg
2016-09-20 20:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905131127.GA3176@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.