From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sauhun.de ([89.238.76.85]:36819 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934334AbcIEQtg (ORCPT ); Mon, 5 Sep 2016 12:49:36 -0400 Date: Mon, 5 Sep 2016 18:49:24 +0200 From: Wolfram Sang To: Vladimir Zapolskiy Cc: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH v5 00/10] watchdog: add watchdog pretimeout framework Message-ID: <20160905164923.GA1548@katana> References: <1472644370-16982-1-git-send-email-vladimir_zapolskiy@mentor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <1472644370-16982-1-git-send-email-vladimir_zapolskiy@mentor.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2016 at 02:52:40PM +0300, Vladimir Zapolskiy wrote: > The change adds a simple watchdog pretimeout framework infrastructure, > its purpose is to allow users to select a desired handling of watchdog > pretimeout events, which may be generated by a watchdog driver. >=20 > The idea of adding this kind of a framework appeared after reviewing > several attempts to add hardcoded pretimeout event handling to some > watchdog driver and after a discussion with Guenter, see > https://lkml.org/lkml/2015/11/4/346 >=20 > Watchdogs with WDIOF_PRETIMEOUT capability now may have three device > attributes in sysfs: read only pretimeout value attribute, read/write > pretimeout_governor attribute, read only pretimeout_available_governors > attribute. >=20 > To throw a pretimeout event for further processing a watchdog driver > should call exported watchdog_notify_pretimeout(wdd) interface. >=20 > In addition to the framework two simple watchdog pretimeout governors > are added for review: panic and noop. >=20 > Changes from v4 to v5: > * fixed in source tree compilation issue, thanks to Wolfram > * replaced strncmp() with more suitable sysfs_streq() to > compare strings passed over sysfs (Wolfram) > * added Wolfram's implementation of pretimeout to softdog driver > * added watchdog pretimeout support to iMX2+ driver > * minor whitespace issue fixes reported by checkpatch Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang So, I checked it on my Renesas M3 Salvator board and it worked as expected. I also looked over the code and it looks good to me. Note that I looked quite often over the code, so a "fresh" view might not hurt. Despite that, I think the code is generally good to go. --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXzaITAAoJEBQN5MwUoCm2XCAP/jiqAsu7RncVOP61/cGMHg4s clA1C4YK2RjOAFd3B5jmKiAjqeOHUmtxim8xBXm9Mled7p8N6Ojz5JV6zdaN8W7y cu5ZIshJ+6XghAQ0DTM7dk5ZBQJfCWW2bvFssSua1ugcUy11yAO6fgIzb0fzGZ6/ Tahdq82lX4Nk4PpSOrZXW5+rTHy8lS+lOLSAhA3BdZDHb2NKNGFhXu9I2CHJmWmY /7kT1rMBnax4XqwtTf8zvyahZ2+Jo0vLPNHKVxpIOlmJhwm4rdFVct0KkG3aLWGg /jluHIEEdUbQyzYLd9Giyd2ygmVuOhRjuhPW5Erf8OYBzAjfXnqbnhpqTL0DtugM YDKVIgIrafMPXa01caWjUYfSRlmoQ5jFDCAwLqzQFSi0/pK9fs7qgzBBAVoNfk4A /qhfISvdGsjP2vN6U624HW0ANBKK2Sla+t5kB8dwaDGJ3r80/0PvNyLB7f+hS8nz 0SfFE5ha9pHHW+KZGhJc6Bbp59YmjuSbvrDQMxmUHQ7ThcRmQi+vBFDh/8g/ady1 EMdWY95d7Y5+0ZN+2GoDKOTlYRGMp1p+ubyqgPB4rZ4aqQEHcjjPmz26pFCQ1lpF 28Yvkl4l3OWHGybqipzxzpVjquNlJp5f+fzTUfph7wYwN+pOyM+zSascJZUUn9d0 dEoicRy8uk30gfTMVDC8 =5T7T -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--