From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released
Date: Mon, 5 Sep 2016 13:54:35 -0400 [thread overview]
Message-ID: <20160905175435.GF24387@stefanha-x1.localdomain> (raw)
In-Reply-To: <38b365e3-4182-d9d9-28d6-275dfad0da8a@kamp.de>
[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]
On Fri, Aug 26, 2016 at 01:45:56PM +0200, Peter Lieven wrote:
> Am 25.08.2016 um 19:23 schrieb Michael Roth:
> > Quoting Peter Lieven (2016-08-25 01:38:13)
> > > 7c509d1 virtio: decrement vq->inuse in virtqueue_discard()
> > > 700f26b virtio: recalculate vq->inuse after migration
> > Looks like these got posted during the freeze :(
> >
> > > The virtio thing is important because live migration is broken without
> > > the fix as 86cc089 is in 2.6.1.
> > Not sure I understand the relation to 86cc089. Wouldn't the check
> > introduced there always pass due to target initializing inuse to 0?
> >
> > Or is the issue that the fix introduced in 86cc089 is only partially
> > effective due to inuse not being recalculated properly on target? That might
> > warrant a 2.6.1.1...
>
> This is what Stefan wrote in the cover letter to the series:
>
> "I should mention this is for QEMU 2.7. These fixes are needed if the
> CVE-2016-5403 patch has been applied. Without these patches any device that holds VirtQueueElements acros
> live migration will terminate with a "Virtqueue size exceeded" error message. virtio-balloon and virtio-scsi are affected. virtio-bl
> probably too but I haven't tested it."
>
> Maybe
The virtio inuse fixes are needed for stable (v2.6.2?) so that the
spurious "Virtqueue size exceeded" on migration is solved.
The error can be reproduced when there is a VirtQueueElement pending
across migration (e.g. virtio-blk s->rq failed request list).
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-09-05 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 19:30 [Qemu-devel] [ANNOUNCE] QEMU 2.6.1 Stable released Michael Roth
2016-08-25 6:38 ` [Qemu-devel] [Qemu-stable] " Peter Lieven
2016-08-25 17:23 ` Michael Roth
2016-08-26 11:45 ` Peter Lieven
2016-09-05 17:54 ` Stefan Hajnoczi [this message]
2016-09-08 20:58 ` Michael Roth
2016-09-13 15:42 ` Stefan Hajnoczi
2016-09-13 15:52 ` Peter Lieven
2016-09-13 18:04 ` Michael Roth
2016-09-13 20:16 ` Peter Lieven
2016-09-16 13:56 ` Peter Lieven
2016-09-27 10:28 ` Peter Lieven
2016-09-27 11:30 ` Peter Lieven
2016-09-28 19:52 ` Michael Roth
2016-09-30 8:17 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905175435.GF24387@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.