From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933687AbcIEUWV (ORCPT ); Mon, 5 Sep 2016 16:22:21 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54973 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754488AbcIEUWU (ORCPT ); Mon, 5 Sep 2016 16:22:20 -0400 Date: Mon, 5 Sep 2016 22:22:18 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Thomas Petazzoni Subject: Re: [PATCH 2/7] drm/sun4i: support A33 tcon Message-ID: <20160905202218.GD8596@lukather> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-3-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tEFtbjk+mNEviIIX" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tEFtbjk+mNEviIIX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2016 at 02:02:30PM +0800, Chen-Yu Tsai wrote: > Hi, >=20 > On Thu, Sep 1, 2016 at 11:31 PM, Maxime Ripard > wrote: > > The A33 has a significantly different pipeline, with components that di= ffer > > too. > > > > Make sure we had compatible for them. > > > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++= ++- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 1 + > > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++= +--- > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 ++++= +++- > > 4 files changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.= txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index df8f4aeefe4c..d467ea93ac08 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -26,7 +26,9 @@ TCON > > The TCON acts as a timing controller for RGB, LVDS and TV interfaces. > > > > Required properties: > > - - compatible: value should be "allwinner,sun5i-a13-tcon". > > + - compatible: value must be either: > > + * allwinner,sun5i-a13-tcon > > + * allwinner,sun8i-a23-tcon >=20 > From what I can tell from the manuals, the A23 TCON and A33 TCON are > slightly different. The A23 TCON has channel 1, and it also has DMA > input. A33 has neither. (Though the DMA chart still lists the TCON DRQ.) >=20 > I think we should have separate compatibles for them. If you think > otherwise you should mention it in the commit message. Ack, i will change it in the v2. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --tEFtbjk+mNEviIIX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXzdP6AAoJEBx+YmzsjxAgC5QQAKGUi4hrHq/w4Jl6c3E1KBe/ NBJHWiVggMrpyCDzyZZqKOw2PL+MAUpsqknjJs25O6/mdlWY48EPWy9enxqX21BI 1f4aV3LAqU3Gwv4Low5JZ8Aky2guO2oyBNbha7dR6ZDXw87kB5eihW080Z6S+Lr0 PfRzQ3fsRtwGmVXMCcnKPQle1OyKNf56R2n2kJswwpHmuE0eu4Bu/MD7097JBqZN Ldxsfy1iojrtAjVG3k6TGjT2ryDS61LHlQ6NRpXkZ+kHsjZ/YvASQyGb/oI31N7h 9tHjPFUUWVoJmzGgwFIERXJzB81O88HMlkSh429/2k9fTUrIpMSr3I7GTjBkogcg VGY9JTJH8VvLw+qzxosc1JEql1EuQeNxJYNJLUAxL88fT3Q+Mbm1bpGy5MtVD03w B1TebrWrKRX3jQuskQqCbTwDbXt2bWxhVM8FBgAimcpSvL0F4KsQYTm63xSReIHd rkkTCHe5iY5IPYTzyHKRbydsV0zgij1ntrdyIaa4uwBKWK1VSL/YcwgQ/6CImt4u BEuLKmRYJHuYuz55vD282eyv2he33D6dRl9K/QQj1toFKPL2PzPqT+zU/XBp3Lzi /AbLIgtk9v4WVLuqzxFZ7xjX1pvsbsJKEME3yrus3J2gqzJwla2YS0sJWYQ1S8DU 8czXqubweZA9mtSyMPxV =UhSV -----END PGP SIGNATURE----- --tEFtbjk+mNEviIIX-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 5 Sep 2016 22:22:18 +0200 Subject: [PATCH 2/7] drm/sun4i: support A33 tcon In-Reply-To: References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-3-maxime.ripard@free-electrons.com> Message-ID: <20160905202218.GD8596@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 02, 2016 at 02:02:30PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Sep 1, 2016 at 11:31 PM, Maxime Ripard > wrote: > > The A33 has a significantly different pipeline, with components that differ > > too. > > > > Make sure we had compatible for them. > > > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++++- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 1 + > > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 +++++--- > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 +++++++- > > 4 files changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index df8f4aeefe4c..d467ea93ac08 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -26,7 +26,9 @@ TCON > > The TCON acts as a timing controller for RGB, LVDS and TV interfaces. > > > > Required properties: > > - - compatible: value should be "allwinner,sun5i-a13-tcon". > > + - compatible: value must be either: > > + * allwinner,sun5i-a13-tcon > > + * allwinner,sun8i-a23-tcon > > From what I can tell from the manuals, the A23 TCON and A33 TCON are > slightly different. The A23 TCON has channel 1, and it also has DMA > input. A33 has neither. (Though the DMA chart still lists the TCON DRQ.) > > I think we should have separate compatibles for them. If you think > otherwise you should mention it in the commit message. Ack, i will change it in the v2. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/7] drm/sun4i: support A33 tcon Date: Mon, 5 Sep 2016 22:22:18 +0200 Message-ID: <20160905202218.GD8596@lukather> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-3-maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0731145065==" Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id ABE5D6E06B for ; Mon, 5 Sep 2016 20:22:19 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: Thomas Petazzoni , linux-kernel , dri-devel , Rob Herring , linux-sunxi , Daniel Vetter , linux-arm-kernel List-Id: dri-devel@lists.freedesktop.org --===============0731145065== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tEFtbjk+mNEviIIX" Content-Disposition: inline --tEFtbjk+mNEviIIX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2016 at 02:02:30PM +0800, Chen-Yu Tsai wrote: > Hi, >=20 > On Thu, Sep 1, 2016 at 11:31 PM, Maxime Ripard > wrote: > > The A33 has a significantly different pipeline, with components that di= ffer > > too. > > > > Make sure we had compatible for them. > > > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++= ++- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 1 + > > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++= +--- > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 ++++= +++- > > 4 files changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.= txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index df8f4aeefe4c..d467ea93ac08 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -26,7 +26,9 @@ TCON > > The TCON acts as a timing controller for RGB, LVDS and TV interfaces. > > > > Required properties: > > - - compatible: value should be "allwinner,sun5i-a13-tcon". > > + - compatible: value must be either: > > + * allwinner,sun5i-a13-tcon > > + * allwinner,sun8i-a23-tcon >=20 > From what I can tell from the manuals, the A23 TCON and A33 TCON are > slightly different. The A23 TCON has channel 1, and it also has DMA > input. A33 has neither. (Though the DMA chart still lists the TCON DRQ.) >=20 > I think we should have separate compatibles for them. If you think > otherwise you should mention it in the commit message. Ack, i will change it in the v2. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --tEFtbjk+mNEviIIX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXzdP6AAoJEBx+YmzsjxAgC5QQAKGUi4hrHq/w4Jl6c3E1KBe/ NBJHWiVggMrpyCDzyZZqKOw2PL+MAUpsqknjJs25O6/mdlWY48EPWy9enxqX21BI 1f4aV3LAqU3Gwv4Low5JZ8Aky2guO2oyBNbha7dR6ZDXw87kB5eihW080Z6S+Lr0 PfRzQ3fsRtwGmVXMCcnKPQle1OyKNf56R2n2kJswwpHmuE0eu4Bu/MD7097JBqZN Ldxsfy1iojrtAjVG3k6TGjT2ryDS61LHlQ6NRpXkZ+kHsjZ/YvASQyGb/oI31N7h 9tHjPFUUWVoJmzGgwFIERXJzB81O88HMlkSh429/2k9fTUrIpMSr3I7GTjBkogcg VGY9JTJH8VvLw+qzxosc1JEql1EuQeNxJYNJLUAxL88fT3Q+Mbm1bpGy5MtVD03w B1TebrWrKRX3jQuskQqCbTwDbXt2bWxhVM8FBgAimcpSvL0F4KsQYTm63xSReIHd rkkTCHe5iY5IPYTzyHKRbydsV0zgij1ntrdyIaa4uwBKWK1VSL/YcwgQ/6CImt4u BEuLKmRYJHuYuz55vD282eyv2he33D6dRl9K/QQj1toFKPL2PzPqT+zU/XBp3Lzi /AbLIgtk9v4WVLuqzxFZ7xjX1pvsbsJKEME3yrus3J2gqzJwla2YS0sJWYQ1S8DU 8czXqubweZA9mtSyMPxV =UhSV -----END PGP SIGNATURE----- --tEFtbjk+mNEviIIX-- --===============0731145065== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0731145065==--