From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934685AbcIEU1W (ORCPT ); Mon, 5 Sep 2016 16:27:22 -0400 Received: from down.free-electrons.com ([37.187.137.238]:55131 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932299AbcIEU1V (ORCPT ); Mon, 5 Sep 2016 16:27:21 -0400 Date: Mon, 5 Sep 2016 22:27:09 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Thomas Petazzoni Subject: Re: [PATCH 3/7] drm/sun4i: Add SAT and DRC drivers Message-ID: <20160905202709.GE8596@lukather> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-4-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8vCeF2GUdMpe9ZbK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8vCeF2GUdMpe9ZbK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Sep 02, 2016 at 02:45:06PM +0800, Chen-Yu Tsai wrote: > > + > > +DRC > > +--- > > + > > +The DRC, found in the latest Allwinner SoCs (A31, A23, A33), allows to > > +do some backlight control to enhance the power consumption. > > + > > +Required properties: > > + - compatible: value must be one of: > > + * allwinner,sun8i-a33-drc >=20 > Since this was first introduced in the A31, maybe using that > for the compatible is better? >=20 > Or do you want one for each SoC, given these are unknown black > boxes? Yeah, I'd prefer to be on the safe side here :/ > > + drc->mod_clk =3D devm_clk_get(dev, "mod"); > > + if (IS_ERR(drc->mod_clk)) { > > + dev_err(dev, "Couldn't get our mod clock\n"); > > + ret =3D PTR_ERR(drc->mod_clk); > > + goto err_disable_bus_clk; > > + } > > + > > + return clk_prepare_enable(drc->mod_clk); >=20 > What happens if this fails? No cleanup happens. Indeed, will fix. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --8vCeF2GUdMpe9ZbK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXzdUdAAoJEBx+YmzsjxAgcCAP/2KBeajN+6S8Hk3c8zSLZMkW e6aDv/NioMJq0jKlTFykBBKJC1SXVHfdDNsQUCry01f/jHo7BydR2Cx0OGxjGuFp pnPcA4iPPAvtMlBkA6eG383FZ7E4FtW1PkQdGNHfdbgu5f7au6jGoV4qGyNIdDGC chxkK3YdjmDRdSdOjmetsxOXEDwgrP7SzT1s9/m98srgdEB6qXdOkfeLlWaFWkp+ PH+N+XTQVH0SHTzUVUn0E+U/+M+qwuBeLqKd7MgLwwrdjxtRr4hC670L6Uw9Nocq pbthzozbGuKqh0/5MmBkOa5Lf3whihLlXpi/tlq+HAPEvm38tL4emamnH3Ov2Ipc o/0wPsGPsXvkJYA61SXheDF3xQkJHB2TcvqRp6Up+P3AB1P3r74XsRNCTFCFcadF QJJmYYQc4SDRaY0dqfYTHQRhFzPST4dlwK3jggc7Ad4f5G2xOZ/4ZFWf+GCEETLl OSGfNftulntxcavPuOmKTb0QbBoHzBdkGhO5LR5BvP7hcbQN+yRMciGiCVI7lEA/ QhvOzO0QGNbZERFe2tTByE5VHJTOe2LNvgpTZ0ITDq7QfiZR3hDmsY+YODvHOMAt 0XcqyZcavl9oRYSdVrvI2Zh298uHVzGnPpMHCt8kMJMIeCnLQ3bT7Rka8CboJFPy bdwBIoMm4Kyn5tSZ0CWK =LNSx -----END PGP SIGNATURE----- --8vCeF2GUdMpe9ZbK-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 5 Sep 2016 22:27:09 +0200 Subject: [PATCH 3/7] drm/sun4i: Add SAT and DRC drivers In-Reply-To: References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-4-maxime.ripard@free-electrons.com> Message-ID: <20160905202709.GE8596@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Fri, Sep 02, 2016 at 02:45:06PM +0800, Chen-Yu Tsai wrote: > > + > > +DRC > > +--- > > + > > +The DRC, found in the latest Allwinner SoCs (A31, A23, A33), allows to > > +do some backlight control to enhance the power consumption. > > + > > +Required properties: > > + - compatible: value must be one of: > > + * allwinner,sun8i-a33-drc > > Since this was first introduced in the A31, maybe using that > for the compatible is better? > > Or do you want one for each SoC, given these are unknown black > boxes? Yeah, I'd prefer to be on the safe side here :/ > > + drc->mod_clk = devm_clk_get(dev, "mod"); > > + if (IS_ERR(drc->mod_clk)) { > > + dev_err(dev, "Couldn't get our mod clock\n"); > > + ret = PTR_ERR(drc->mod_clk); > > + goto err_disable_bus_clk; > > + } > > + > > + return clk_prepare_enable(drc->mod_clk); > > What happens if this fails? No cleanup happens. Indeed, will fix. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 3/7] drm/sun4i: Add SAT and DRC drivers Date: Mon, 5 Sep 2016 22:27:09 +0200 Message-ID: <20160905202709.GE8596@lukather> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-4-maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1651379040==" Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DF016E513 for ; Mon, 5 Sep 2016 20:27:21 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: Thomas Petazzoni , linux-kernel , dri-devel , Rob Herring , linux-sunxi , Daniel Vetter , linux-arm-kernel List-Id: dri-devel@lists.freedesktop.org --===============1651379040== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8vCeF2GUdMpe9ZbK" Content-Disposition: inline --8vCeF2GUdMpe9ZbK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Sep 02, 2016 at 02:45:06PM +0800, Chen-Yu Tsai wrote: > > + > > +DRC > > +--- > > + > > +The DRC, found in the latest Allwinner SoCs (A31, A23, A33), allows to > > +do some backlight control to enhance the power consumption. > > + > > +Required properties: > > + - compatible: value must be one of: > > + * allwinner,sun8i-a33-drc >=20 > Since this was first introduced in the A31, maybe using that > for the compatible is better? >=20 > Or do you want one for each SoC, given these are unknown black > boxes? Yeah, I'd prefer to be on the safe side here :/ > > + drc->mod_clk =3D devm_clk_get(dev, "mod"); > > + if (IS_ERR(drc->mod_clk)) { > > + dev_err(dev, "Couldn't get our mod clock\n"); > > + ret =3D PTR_ERR(drc->mod_clk); > > + goto err_disable_bus_clk; > > + } > > + > > + return clk_prepare_enable(drc->mod_clk); >=20 > What happens if this fails? No cleanup happens. Indeed, will fix. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --8vCeF2GUdMpe9ZbK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXzdUdAAoJEBx+YmzsjxAgcCAP/2KBeajN+6S8Hk3c8zSLZMkW e6aDv/NioMJq0jKlTFykBBKJC1SXVHfdDNsQUCry01f/jHo7BydR2Cx0OGxjGuFp pnPcA4iPPAvtMlBkA6eG383FZ7E4FtW1PkQdGNHfdbgu5f7au6jGoV4qGyNIdDGC chxkK3YdjmDRdSdOjmetsxOXEDwgrP7SzT1s9/m98srgdEB6qXdOkfeLlWaFWkp+ PH+N+XTQVH0SHTzUVUn0E+U/+M+qwuBeLqKd7MgLwwrdjxtRr4hC670L6Uw9Nocq pbthzozbGuKqh0/5MmBkOa5Lf3whihLlXpi/tlq+HAPEvm38tL4emamnH3Ov2Ipc o/0wPsGPsXvkJYA61SXheDF3xQkJHB2TcvqRp6Up+P3AB1P3r74XsRNCTFCFcadF QJJmYYQc4SDRaY0dqfYTHQRhFzPST4dlwK3jggc7Ad4f5G2xOZ/4ZFWf+GCEETLl OSGfNftulntxcavPuOmKTb0QbBoHzBdkGhO5LR5BvP7hcbQN+yRMciGiCVI7lEA/ QhvOzO0QGNbZERFe2tTByE5VHJTOe2LNvgpTZ0ITDq7QfiZR3hDmsY+YODvHOMAt 0XcqyZcavl9oRYSdVrvI2Zh298uHVzGnPpMHCt8kMJMIeCnLQ3bT7Rka8CboJFPy bdwBIoMm4Kyn5tSZ0CWK =LNSx -----END PGP SIGNATURE----- --8vCeF2GUdMpe9ZbK-- --===============1651379040== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1651379040==--