From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933572AbcIEWCm (ORCPT ); Mon, 5 Sep 2016 18:02:42 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:38971 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbcIEWCj (ORCPT ); Mon, 5 Sep 2016 18:02:39 -0400 X-Greylist: delayed 412 seconds by postgrey-1.27 at vger.kernel.org; Mon, 05 Sep 2016 18:02:39 EDT Date: Mon, 5 Sep 2016 23:55:43 +0200 From: Samuel Thibault To: Pavel Andrianov Cc: William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , Shraddha Barke , Dilek Uzulmez , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, vaishali.thakkar@oracle.com, ldv-project@linuxtesting.org Subject: Re: [PATCH] speakup: Add spinlock in synth_direct_store Message-ID: <20160905215543.GO4779@var.home> Mail-Followup-To: Samuel Thibault , Pavel Andrianov , William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , Shraddha Barke , Dilek Uzulmez , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, vaishali.thakkar@oracle.com, ldv-project@linuxtesting.org References: <1473081467-1892-1-git-send-email-andrianov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473081467-1892-1-git-send-email-andrianov@ispras.ru> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Andrianov, on Mon 05 Sep 2016 16:17:47 +0300, wrote: > All operations with synth buffer should be protected, > as there are global pointers, which should be modified atomically. > > Found by Linux Driver Verification project (linuxtesting.org) > > Signed-off-by: Pavel Andrianov Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index 528cbdc..7fedee3 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -411,11 +411,13 @@ static ssize_t synth_direct_store(struct kobject *kobj, > int len; > int bytes; > const char *ptr = buf; > + unsigned long flags; > > if (!synth) > return -EPERM; > > len = strlen(buf); > + spin_lock_irqsave(&speakup_info.spinlock, flags); > while (len > 0) { > bytes = min_t(size_t, len, 250); > strncpy(tmp, ptr, bytes); > @@ -425,6 +427,7 @@ static ssize_t synth_direct_store(struct kobject *kobj, > ptr += bytes; > len -= bytes; > } > + spin_unlock_irqrestore(&speakup_info.spinlock, flags); > return count; > } > > -- > 2.7.4 > -- Samuel Linux, c'est simple : ça s'adresse à une machine qui est parfois un peu maraboutée mais qui d'habitude n'a pas d'états d'âme. Sur Usenet y'a plein d'humains et de primates, et ça devient vraiment gore par moment. -+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une âme ?" -+-