All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: helmut.buchsbaum@gmail.com
Cc: nicolas.ferre@atmel.com, tom@herbertland.com,
	michal.simek@xilinx.com, netdev@vger.kernel.org,
	cyrille.pitchen@atmel.com
Subject: Re: [PATCH v3] net: macb: initialize checksum when using checksum offloading
Date: Tue, 06 Sep 2016 13:43:59 -0700 (PDT)	[thread overview]
Message-ID: <20160906.134359.334009778514208272.davem@davemloft.net> (raw)
In-Reply-To: <1473005387-24917-1-git-send-email-helmut.buchsbaum@gmail.com>

From: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Date: Sun,  4 Sep 2016 18:09:47 +0200

> I'm still struggling to get this fix right..
> 
> Changes since v2:
>  - do not blindly modify SKB contents according to Dave's legitimate
>    objection
> 
> Changes since v1:
>  - dropped disabling HW checksum offload for Zynq
>  - initialize checksum similar to net/ethernet/freescale/fec_main.c
> 
> -- >8 --
> MACB/GEM needs the checksum field initialized to 0 to get correct
> results on transmit in all cases, e.g. on Zynq, UDP packets with
> payload <= 2 otherwise contain a wrong checksums.
> 
> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>

Applied.

  reply	other threads:[~2016-09-06 20:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 13:04 [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM Helmut Buchsbaum
2016-08-19 13:04 ` [PATCH 1/1] net: macb: disable HW checksum offload for Xilinx Zynq Helmut Buchsbaum
2016-08-29 13:57   ` [PATCH v2 0/1] net: macb: initialize checksum when using checksum Helmut Buchsbaum
2016-08-29 13:57     ` [PATCH v2 1/1] net: macb: initialize checksum when using checksum offloading Helmut Buchsbaum
2016-09-01 17:03       ` David Miller
2016-09-04 16:09       ` [PATCH v3] " Helmut Buchsbaum
2016-09-06 20:43         ` David Miller [this message]
2016-08-19 19:28 ` [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM David Miller
2016-08-19 20:00   ` Tom Herbert
2016-08-23  5:39     ` Helmut Buchsbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906.134359.334009778514208272.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cyrille.pitchen@atmel.com \
    --cc=helmut.buchsbaum@gmail.com \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.