From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934359AbcIFX5a (ORCPT ); Tue, 6 Sep 2016 19:57:30 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:56942 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755264AbcIFX53 (ORCPT ); Tue, 6 Sep 2016 19:57:29 -0400 Date: Tue, 06 Sep 2016 16:57:28 -0700 (PDT) Message-Id: <20160906.165728.124928924200975859.davem@davemloft.net> To: arnd@arndb.de Cc: richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ptp: ixp46x: remove NO_IRQ handling From: David Miller In-Reply-To: <20160906192053.1061021-1-arnd@arndb.de> References: <20160906192053.1061021-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Sep 2016 16:57:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 6 Sep 2016 21:20:36 +0200 > gpio_to_irq does not return NO_IRQ but instead returns a negative > error code on failure. Returning NO_IRQ from the function has no > negative effects as we only compare the result to the expected > interrupt number, but it's better to return a proper failure > code for consistency, and we should remove NO_IRQ from the kernel > entirely. > > Signed-off-by: Arnd Bergmann > Acked-by: Richard Cochran Applied to net-next, thanks.