From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bh5bS-0001Cp-H0
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 21:55:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bh5bO-0005w2-Aj
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 21:55:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36966)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bh5bO-0005vf-5o
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 21:55:06 -0400
Date: Tue, 6 Sep 2016 09:47:51 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160906014751.GC653@al.usersys.redhat.com>
References: <1472063464-790-1-git-send-email-silbe@linux.vnet.ibm.com>
	<1472063464-790-4-git-send-email-silbe@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1472063464-790-4-git-send-email-silbe@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print
 helpful message if DEB_ARCH/DEB_TYPE unset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>

On Wed, 08/24 20:30, Sascha Silbe wrote:
> The debian-bootstrap image doesn't choose a default architecture and
> distribution version, instead the user has to set both DEB_ARCH and
> DEB_TYPE in the environment. Print a reasonably helpful message if
> either of them isn't set instead of complaining about "qemu-" being
> missing or erroring out because we cannot cd to the mirror URL.
> 
> Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
> ---
>  tests/docker/dockerfiles/debian-bootstrap.pre | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/dockerfiles/debian-bootstrap.pre
> index 5d9c8d5..2ae363f 100755
> --- a/tests/docker/dockerfiles/debian-bootstrap.pre
> +++ b/tests/docker/dockerfiles/debian-bootstrap.pre
> @@ -15,6 +15,19 @@ exit_and_skip()
>  if [ -z $FAKEROOT ]; then
>      echo "Please install fakeroot to enable bootstraping"
>      exit_and_skip
> +
> +fi
> +
> +if [ -z "${DEB_ARCH}" ]; then
> +    echo "Please set DEB_ARCH to choose an architecture (e.g. armhf)"
> +    exit_and_skip
> +
> +fi
> +
> +if [ -z "${DEB_TYPE}" ]; then
> +    echo "Please set DEB_TYPE to a Debian archive name (e.g. testing)"
> +    exit_and_skip
> +
>  fi
>  
>  # We check in order for
> -- 
> 1.9.1
> 

Can you also update the three 'echo' commands to output the message to stderr?

Fam