From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932600AbcIFGU2 (ORCPT ); Tue, 6 Sep 2016 02:20:28 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35469 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183AbcIFGUZ (ORCPT ); Tue, 6 Sep 2016 02:20:25 -0400 Date: Tue, 6 Sep 2016 08:22:52 +0200 From: Christoffer Dall To: Punit Agrawal Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Steven Rostedt , Ingo Molnar , Will Deacon , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [RFC v2 PATCH 2/7] KVM: Track the pid of the VM process Message-ID: <20160906062252.GA30513@cbox> References: <1473093097-30932-1-git-send-email-punit.agrawal@arm.com> <1473093097-30932-3-git-send-email-punit.agrawal@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473093097-30932-3-git-send-email-punit.agrawal@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2016 at 05:31:32PM +0100, Punit Agrawal wrote: > Userspace tools such as perf can be used to profile individual > processes. > > Track the PID of the virtual machine process to match profiling requests > targeted at it. This can be used to take appropriate action to enable > the requested profiling operations for the VMs of interest. > > Signed-off-by: Punit Agrawal > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Christoffer Dall > Cc: Marc Zyngier > --- > include/linux/kvm_host.h | 1 + > virt/kvm/kvm_main.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 9c28b4d..7c42c94 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -374,6 +374,7 @@ struct kvm_memslots { > struct kvm { > spinlock_t mmu_lock; > struct mutex slots_lock; > + struct pid *pid; > struct mm_struct *mm; /* userspace tied to this vm */ > struct kvm_memslots *memslots[KVM_ADDRESS_SPACE_NUM]; > struct srcu_struct srcu; > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 1950782..ab2535a 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -613,6 +613,7 @@ static struct kvm *kvm_create_vm(unsigned long type) > spin_lock_init(&kvm->mmu_lock); > atomic_inc(¤t->mm->mm_count); > kvm->mm = current->mm; > + kvm->pid = get_task_pid(current, PIDTYPE_PID); How dooes this deal with threading? Is the idea that the user by specifying the main thread's pid will enable trapping for all vcpu threads belonging to that VM? > kvm_eventfd_init(kvm); > mutex_init(&kvm->lock); > mutex_init(&kvm->irq_lock); > @@ -712,6 +713,7 @@ static void kvm_destroy_vm(struct kvm *kvm) > int i; > struct mm_struct *mm = kvm->mm; > > + put_pid(kvm->pid); > kvm_destroy_vm_debugfs(kvm); > kvm_arch_sync_events(kvm); > spin_lock(&kvm_lock); > -- > 2.8.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [RFC v2 PATCH 2/7] KVM: Track the pid of the VM process Date: Tue, 6 Sep 2016 08:22:52 +0200 Message-ID: <20160906062252.GA30513@cbox> References: <1473093097-30932-1-git-send-email-punit.agrawal@arm.com> <1473093097-30932-3-git-send-email-punit.agrawal@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm@vger.kernel.org, Marc Zyngier , Will Deacon , linux-kernel@vger.kernel.org, Steven Rostedt , Ingo Molnar , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Punit Agrawal Return-path: Content-Disposition: inline In-Reply-To: <1473093097-30932-3-git-send-email-punit.agrawal@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org T24gTW9uLCBTZXAgMDUsIDIwMTYgYXQgMDU6MzE6MzJQTSArMDEwMCwgUHVuaXQgQWdyYXdhbCB3 cm90ZToKPiBVc2Vyc3BhY2UgdG9vbHMgc3VjaCBhcyBwZXJmIGNhbiBiZSB1c2VkIHRvIHByb2Zp bGUgaW5kaXZpZHVhbAo+IHByb2Nlc3Nlcy4KPiAKPiBUcmFjayB0aGUgUElEIG9mIHRoZSB2aXJ0 dWFsIG1hY2hpbmUgcHJvY2VzcyB0byBtYXRjaCBwcm9maWxpbmcgcmVxdWVzdHMKPiB0YXJnZXRl ZCBhdCBpdC4gVGhpcyBjYW4gYmUgdXNlZCB0byB0YWtlIGFwcHJvcHJpYXRlIGFjdGlvbiB0byBl bmFibGUKPiB0aGUgcmVxdWVzdGVkIHByb2ZpbGluZyBvcGVyYXRpb25zIGZvciB0aGUgVk1zIG9m IGludGVyZXN0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFB1bml0IEFncmF3YWwgPHB1bml0LmFncmF3 YWxAYXJtLmNvbT4KPiBDYzogUGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT4KPiBD YzogIlJhZGltIEtyxI1tw6HFmSIgPHJrcmNtYXJAcmVkaGF0LmNvbT4KPiBDYzogQ2hyaXN0b2Zm ZXIgRGFsbCA8Y2hyaXN0b2ZmZXIuZGFsbEBsaW5hcm8ub3JnPgo+IENjOiBNYXJjIFp5bmdpZXIg PG1hcmMuenluZ2llckBhcm0uY29tPgo+IC0tLQo+ICBpbmNsdWRlL2xpbnV4L2t2bV9ob3N0Lmgg fCAxICsKPiAgdmlydC9rdm0va3ZtX21haW4uYyAgICAgIHwgMiArKwo+ICAyIGZpbGVzIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2t2bV9o b3N0LmggYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPiBpbmRleCA5YzI4YjRkLi43YzQyYzk0 IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgva3ZtX2hvc3QuaAo+ICsrKyBiL2luY2x1ZGUv bGludXgva3ZtX2hvc3QuaAo+IEBAIC0zNzQsNiArMzc0LDcgQEAgc3RydWN0IGt2bV9tZW1zbG90 cyB7Cj4gIHN0cnVjdCBrdm0gewo+ICAJc3BpbmxvY2tfdCBtbXVfbG9jazsKPiAgCXN0cnVjdCBt dXRleCBzbG90c19sb2NrOwo+ICsJc3RydWN0IHBpZCAqcGlkOwo+ICAJc3RydWN0IG1tX3N0cnVj dCAqbW07IC8qIHVzZXJzcGFjZSB0aWVkIHRvIHRoaXMgdm0gKi8KPiAgCXN0cnVjdCBrdm1fbWVt c2xvdHMgKm1lbXNsb3RzW0tWTV9BRERSRVNTX1NQQUNFX05VTV07Cj4gIAlzdHJ1Y3Qgc3JjdV9z dHJ1Y3Qgc3JjdTsKPiBkaWZmIC0tZ2l0IGEvdmlydC9rdm0va3ZtX21haW4uYyBiL3ZpcnQva3Zt L2t2bV9tYWluLmMKPiBpbmRleCAxOTUwNzgyLi5hYjI1MzVhIDEwMDY0NAo+IC0tLSBhL3ZpcnQv a3ZtL2t2bV9tYWluLmMKPiArKysgYi92aXJ0L2t2bS9rdm1fbWFpbi5jCj4gQEAgLTYxMyw2ICs2 MTMsNyBAQCBzdGF0aWMgc3RydWN0IGt2bSAqa3ZtX2NyZWF0ZV92bSh1bnNpZ25lZCBsb25nIHR5 cGUpCj4gIAlzcGluX2xvY2tfaW5pdCgma3ZtLT5tbXVfbG9jayk7Cj4gIAlhdG9taWNfaW5jKCZj dXJyZW50LT5tbS0+bW1fY291bnQpOwo+ICAJa3ZtLT5tbSA9IGN1cnJlbnQtPm1tOwo+ICsJa3Zt LT5waWQgPSBnZXRfdGFza19waWQoY3VycmVudCwgUElEVFlQRV9QSUQpOwoKSG93IGRvb2VzIHRo aXMgZGVhbCB3aXRoIHRocmVhZGluZz8gIElzIHRoZSBpZGVhIHRoYXQgdGhlIHVzZXIgYnkKc3Bl Y2lmeWluZyB0aGUgbWFpbiB0aHJlYWQncyBwaWQgd2lsbCBlbmFibGUgdHJhcHBpbmcgZm9yIGFs bCB2Y3B1CnRocmVhZHMgYmVsb25naW5nIHRvIHRoYXQgVk0/Cgo+ICAJa3ZtX2V2ZW50ZmRfaW5p dChrdm0pOwo+ICAJbXV0ZXhfaW5pdCgma3ZtLT5sb2NrKTsKPiAgCW11dGV4X2luaXQoJmt2bS0+ aXJxX2xvY2spOwo+IEBAIC03MTIsNiArNzEzLDcgQEAgc3RhdGljIHZvaWQga3ZtX2Rlc3Ryb3lf dm0oc3RydWN0IGt2bSAqa3ZtKQo+ICAJaW50IGk7Cj4gIAlzdHJ1Y3QgbW1fc3RydWN0ICptbSA9 IGt2bS0+bW07Cj4gIAo+ICsJcHV0X3BpZChrdm0tPnBpZCk7Cj4gIAlrdm1fZGVzdHJveV92bV9k ZWJ1Z2ZzKGt2bSk7Cj4gIAlrdm1fYXJjaF9zeW5jX2V2ZW50cyhrdm0pOwo+ICAJc3Bpbl9sb2Nr KCZrdm1fbG9jayk7Cj4gLS0gCj4gMi44LjEKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3Mu Y29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGlu Zm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: christoffer.dall@linaro.org (Christoffer Dall) Date: Tue, 6 Sep 2016 08:22:52 +0200 Subject: [RFC v2 PATCH 2/7] KVM: Track the pid of the VM process In-Reply-To: <1473093097-30932-3-git-send-email-punit.agrawal@arm.com> References: <1473093097-30932-1-git-send-email-punit.agrawal@arm.com> <1473093097-30932-3-git-send-email-punit.agrawal@arm.com> Message-ID: <20160906062252.GA30513@cbox> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 05, 2016 at 05:31:32PM +0100, Punit Agrawal wrote: > Userspace tools such as perf can be used to profile individual > processes. > > Track the PID of the virtual machine process to match profiling requests > targeted at it. This can be used to take appropriate action to enable > the requested profiling operations for the VMs of interest. > > Signed-off-by: Punit Agrawal > Cc: Paolo Bonzini > Cc: "Radim Kr?m??" > Cc: Christoffer Dall > Cc: Marc Zyngier > --- > include/linux/kvm_host.h | 1 + > virt/kvm/kvm_main.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 9c28b4d..7c42c94 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -374,6 +374,7 @@ struct kvm_memslots { > struct kvm { > spinlock_t mmu_lock; > struct mutex slots_lock; > + struct pid *pid; > struct mm_struct *mm; /* userspace tied to this vm */ > struct kvm_memslots *memslots[KVM_ADDRESS_SPACE_NUM]; > struct srcu_struct srcu; > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 1950782..ab2535a 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -613,6 +613,7 @@ static struct kvm *kvm_create_vm(unsigned long type) > spin_lock_init(&kvm->mmu_lock); > atomic_inc(¤t->mm->mm_count); > kvm->mm = current->mm; > + kvm->pid = get_task_pid(current, PIDTYPE_PID); How dooes this deal with threading? Is the idea that the user by specifying the main thread's pid will enable trapping for all vcpu threads belonging to that VM? > kvm_eventfd_init(kvm); > mutex_init(&kvm->lock); > mutex_init(&kvm->irq_lock); > @@ -712,6 +713,7 @@ static void kvm_destroy_vm(struct kvm *kvm) > int i; > struct mm_struct *mm = kvm->mm; > > + put_pid(kvm->pid); > kvm_destroy_vm_debugfs(kvm); > kvm_arch_sync_events(kvm); > spin_lock(&kvm_lock); > -- > 2.8.1 >