From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhDQX-0005Rg-Bu for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:16:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhDQT-0000Tc-4e for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:16:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhDQS-0000TY-VA for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:16:21 -0400 Date: Tue, 6 Sep 2016 18:09:07 +0800 From: Fam Zheng Message-ID: <20160906100907.GA10962@al.usersys.redhat.com> References: <1471935390-126476-1-git-send-email-ashish.mittal@veritas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471935390-126476-1-git-send-email-ashish.mittal@veritas.com> Subject: Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashish Mittal Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com, ashish.mittal@veritas.com, stefanha@gmail.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com On Mon, 08/22 23:56, Ashish Mittal wrote: > block/Makefile.objs | 2 + > block/trace-events | 41 ++ > block/vxhs.c | 1304 +++++++++++++++++++++++++++++++++++++++++++++++++++ > block/vxhs.h | 237 ++++++++++ > configure | 50 ++ If vxhs code is contained in one file, no need to add vxhs.h and all forward declarations can go to vxhs.c. Then local functions can be marked as "static", and all unused functions can be cleaned up. Fam