From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGVk-0001tC-1T for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhGVg-0007lZ-AE for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:34:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGVg-0007lR-2P for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:33:56 -0400 Date: Tue, 6 Sep 2016 14:33:49 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160906133349.GH2041@work-vm> References: <1473157086-12062-1-git-send-email-dgilbert@redhat.com> <20160906130843.GI10095@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20160906130843.GI10095@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, pbonzini@redhat.com, kwolf@redhat.com, arei.gonglei@huawei.com * Daniel P. Berrange (berrange@redhat.com) wrote: > On Tue, Sep 06, 2016 at 11:18:06AM +0100, Dr. David Alan Gilbert (git) = wrote: > > From: "Dr. David Alan Gilbert" > >=20 > > This started off as Andreas F=E4rber's implementation from > > March 2015, but after feedback from Paolo morphed into > > using the json output which handles structs reasonably. > >=20 > > Use with qom-list to find the members of an object. > >=20 > > (qemu) qom-get /backend/console[0]/device/vga.rom[0] size > > 65536 > > (qemu) qom-get /machine smm > > "auto" > > (qemu) qom-get /machine rtc-time > > { > > "tm_year": 116, > > "tm_sec": 0, > > "tm_hour": 9, > > "tm_min": 46, > > "tm_mon": 8, > > "tm_mday": 6 > > } >=20 > I'm not really a fan of us exposing JSON in the HMP, as it rather > seems to defeat the purpose of using the HMP. Well as long as it's clear and easily readable by humans I'm OK about it; and I'm less fussed about it on the output side; JSON is much more painfu= l to use as human typed input. > > -- > > v2 > > switched from using string-output-visitor to qobject_to_json_pretty= , > > drop string-output-visitor patch. >=20 > IIUC, you switched because string-output-visitor could not handle > complex types. >=20 > I have previously written a text-output-visitor that could do > this correctly, since we have this exact same requirement for > 'qemu-info info' to print out the extra-block specific data > in human friendly format for the LUKS driver. >=20 > https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg01727.html How close to going in is it? It looks from the comments that Eric is thinking about fixing string-output-visitor. I'm not clear why you'd want a text-output-visitor and a string-output-vi= stior. > With your example that ought to lead to output looking like >=20 > (qemu) qom-get /machine rtc-time > tm_year: 116 > tm_sec: 0 > tm_hour: 9 > tm_min: 46 > tm_mon: 8 > tm_mday: 6 >=20 > which i think is more suitable for the HMP. Yes, it's a little prettier; I'm not fussed either way - but I just want = to make sure that we do end up with a qom-get; it's something I'd have found useful in the past and I know others would have, and the code for it was originally written by Andreas ~2.5 years ago - so if text-output-visitor = is imminent then sure, but if it's not then I suggest we stick with this. Dave >=20 > Regards, > Daniel > --=20 > |: http://berrange.com -o- http://www.flickr.com/photos/dberran= ge/ :| > |: http://libvirt.org -o- http://virt-manager.= org :| > |: http://autobuild.org -o- http://search.cpan.org/~danbe= rr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-= vnc :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK