* [PATCH] nvme: add back dependency on CONFIG_BLOCK
@ 2016-09-06 12:58 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-06 12:58 UTC (permalink / raw)
To: Keith Busch, Jens Axboe
Cc: Christoph Hellwig, Arnd Bergmann, Jay Freyensee, Sagi Grimberg,
Ming Lin, Jay Sternberg, linux-nvme, linux-kernel
A recent change removed the dependency on BLK_DEV_NVME, which implies
the dependency on PCI and BLOCK. We don't need CONFIG_PCI, but without
CONFIG_BLOCK we get tons of build errors, e.g.
In file included from drivers/nvme/host/core.c:16:0:
linux/blk-mq.h:182:33: error: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
drivers/nvme/host/core.c: In function 'nvme_setup_rw':
drivers/nvme/host/core.c:295:21: error: implicit declaration of function 'rq_data_dir' [-Werror=implicit-function-declaration]
drivers/nvme/host/nvme.h: In function 'nvme_map_len':
drivers/nvme/host/nvme.h:217:6: error: implicit declaration of function 'req_op' [-Werror=implicit-function-declaration]
drivers/nvme/host/scsi.c: In function 'nvme_trans_bdev_limits_page':
drivers/nvme/host/scsi.c:768:85: error: implicit declaration of function 'queue_max_hw_sectors' [-Werror=implicit-function-declaration]
This adds back the specific CONFIG_BLOCK dependency to avoid broken
configurations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: aa71987472a9 ("nvme: fabrics drivers don't need the nvme-pci driver")
---
drivers/nvme/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 0c644f7bdf80..4b6cfff4b5be 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -31,6 +31,7 @@ config NVME_FABRICS
config NVME_RDMA
tristate "NVM Express over Fabrics RDMA host driver"
depends on INFINIBAND
+ depends on BLOCK
select NVME_CORE
select NVME_FABRICS
select SG_POOL
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] nvme: add back dependency on CONFIG_BLOCK
@ 2016-09-06 12:58 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-06 12:58 UTC (permalink / raw)
A recent change removed the dependency on BLK_DEV_NVME, which implies
the dependency on PCI and BLOCK. We don't need CONFIG_PCI, but without
CONFIG_BLOCK we get tons of build errors, e.g.
In file included from drivers/nvme/host/core.c:16:0:
linux/blk-mq.h:182:33: error: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
drivers/nvme/host/core.c: In function 'nvme_setup_rw':
drivers/nvme/host/core.c:295:21: error: implicit declaration of function 'rq_data_dir' [-Werror=implicit-function-declaration]
drivers/nvme/host/nvme.h: In function 'nvme_map_len':
drivers/nvme/host/nvme.h:217:6: error: implicit declaration of function 'req_op' [-Werror=implicit-function-declaration]
drivers/nvme/host/scsi.c: In function 'nvme_trans_bdev_limits_page':
drivers/nvme/host/scsi.c:768:85: error: implicit declaration of function 'queue_max_hw_sectors' [-Werror=implicit-function-declaration]
This adds back the specific CONFIG_BLOCK dependency to avoid broken
configurations.
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Fixes: aa71987472a9 ("nvme: fabrics drivers don't need the nvme-pci driver")
---
drivers/nvme/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 0c644f7bdf80..4b6cfff4b5be 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -31,6 +31,7 @@ config NVME_FABRICS
config NVME_RDMA
tristate "NVM Express over Fabrics RDMA host driver"
depends on INFINIBAND
+ depends on BLOCK
select NVME_CORE
select NVME_FABRICS
select SG_POOL
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme: add back dependency on CONFIG_BLOCK
2016-09-06 12:58 ` Arnd Bergmann
@ 2016-09-06 13:09 ` Sagi Grimberg
-1 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2016-09-06 13:09 UTC (permalink / raw)
To: Arnd Bergmann, Keith Busch, Jens Axboe
Cc: Christoph Hellwig, Jay Freyensee, Ming Lin, Jay Sternberg,
linux-nvme, linux-kernel
> A recent change removed the dependency on BLK_DEV_NVME, which implies
> the dependency on PCI and BLOCK. We don't need CONFIG_PCI, but without
> CONFIG_BLOCK we get tons of build errors, e.g.
Thanks Arnd, queued for the next round of rc fixes.
With a slight modification to the component in the subject line
(nvme-rdma).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvme: add back dependency on CONFIG_BLOCK
@ 2016-09-06 13:09 ` Sagi Grimberg
0 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2016-09-06 13:09 UTC (permalink / raw)
> A recent change removed the dependency on BLK_DEV_NVME, which implies
> the dependency on PCI and BLOCK. We don't need CONFIG_PCI, but without
> CONFIG_BLOCK we get tons of build errors, e.g.
Thanks Arnd, queued for the next round of rc fixes.
With a slight modification to the component in the subject line
(nvme-rdma).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme: add back dependency on CONFIG_BLOCK
2016-09-06 13:09 ` Sagi Grimberg
@ 2016-09-06 13:36 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-09-06 13:36 UTC (permalink / raw)
To: Sagi Grimberg
Cc: Arnd Bergmann, Keith Busch, Jens Axboe, Ming Lin, Jay Sternberg,
linux-kernel, linux-nvme, Jay Freyensee, Christoph Hellwig
On Tue, Sep 06, 2016 at 04:09:26PM +0300, Sagi Grimberg wrote:
> Thanks Arnd, queued for the next round of rc fixes.
>
> With a slight modification to the component in the subject line
> (nvme-rdma).
Shouldn't we just have a if BLOCK around all the entries in the Kconfig?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvme: add back dependency on CONFIG_BLOCK
@ 2016-09-06 13:36 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-09-06 13:36 UTC (permalink / raw)
On Tue, Sep 06, 2016@04:09:26PM +0300, Sagi Grimberg wrote:
> Thanks Arnd, queued for the next round of rc fixes.
>
> With a slight modification to the component in the subject line
> (nvme-rdma).
Shouldn't we just have a if BLOCK around all the entries in the Kconfig?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-06 13:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 12:58 [PATCH] nvme: add back dependency on CONFIG_BLOCK Arnd Bergmann
2016-09-06 12:58 ` Arnd Bergmann
2016-09-06 13:09 ` Sagi Grimberg
2016-09-06 13:09 ` Sagi Grimberg
2016-09-06 13:36 ` Christoph Hellwig
2016-09-06 13:36 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.