From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGfe-0002Me-T3 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhGfb-0001y0-8J for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:44:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGfb-0001xq-2G for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:44:11 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CB524E4CE for ; Tue, 6 Sep 2016 13:44:10 +0000 (UTC) Date: Tue, 6 Sep 2016 14:44:07 +0100 From: "Daniel P. Berrange" Message-ID: <20160906134407.GJ10095@redhat.com> Reply-To: "Daniel P. Berrange" References: <20160906133637.32147-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160906133637.32147-1-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org On Tue, Sep 06, 2016 at 05:36:37PM +0400, Marc-Andr=C3=A9 Lureau wrote: > srcfifo && dstfifo must still be freed if socat is not present. >=20 > Only unlink if the fifo was actually created. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/test-io-channel-command.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Signed-off-by: Daniel P. Berrange I'll add this to my I/O queue unless you respin your current PULL request with this included. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|