All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: dan.j.williamps@intel.com, rrichter@cavium.com,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] ahci: use pci_alloc_irq_vectors
Date: Tue, 6 Sep 2016 12:39:46 -0400	[thread overview]
Message-ID: <20160906163946.GB24268@htj.duckdns.org> (raw)
In-Reply-To: <1473088905-27670-2-git-send-email-hch@lst.de>

On Mon, Sep 05, 2016 at 05:21:45PM +0200, Christoph Hellwig wrote:
> Use the new pci_alloc_irq_vectors API to allocate MSI-X and MSI vectors.
> The big advantage over the old code is that we can use the same API for
> MSI and MSI-X, and that we don't need to store the MSI-X vector mapping
> in driver-private data structures.
> 
> This first conversion keeps the probe order as-is: MSI-X multi vector,
> MSI multi vector, MSI single vector, MSI-X single vector and last a
> single least legacy interrupt line.  There is one small change of
> behavior: we now check the "MSI Revert to Single Message" flag for
> MSI-X in addition to MSI.
> 
> Because the API to find the Linux IRQ number for a MSI/MSI-X vector
> is PCI specific, but libahaci is bus-agnostic I had to a
> get_irq_vector function pointer to struct ahci_host_priv.  The
> alternative would be to move the multi-vector case of ahci_host_activate
> to ahci.c and just call ata_host_activate directly from the others
> users of ahci_host_activate.

Applied to libata/for-4.9 after pulling in the mainline.

Thanks.

-- 
tejun

  reply	other threads:[~2016-09-06 16:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 15:21 (unknown), Christoph Hellwig
2016-09-05 15:21 ` [PATCH] ahci: use pci_alloc_irq_vectors Christoph Hellwig
2016-09-06 16:39   ` Tejun Heo [this message]
2016-10-20 15:47     ` Robert Richter
2016-10-20 15:47       ` Robert Richter
2016-10-21 12:59       ` Christoph Hellwig
2016-10-21 12:59         ` Christoph Hellwig
2016-10-21 14:01         ` Robert Richter
2016-10-21 14:01           ` Robert Richter
2016-10-22 14:11           ` Christoph Hellwig
2016-10-22 14:11             ` Christoph Hellwig
2016-10-24 18:57             ` David Daney
2016-10-24 18:57               ` David Daney
2016-10-24 19:21               ` Christoph Hellwig
2016-10-24 19:21                 ` Christoph Hellwig
2016-10-24 20:29             ` David Daney
2016-10-24 20:29               ` David Daney
2016-10-25  9:25             ` Robert Richter
2016-10-25  9:25               ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906163946.GB24268@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=dan.j.williamps@intel.com \
    --cc=hch@lst.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=rrichter@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.