From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bhS3e-0000jB-6M
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 21:53:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bhS3Y-00063U-JY
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 21:53:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bhS3Y-00063O-E6
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 21:53:40 -0400
Date: Wed, 7 Sep 2016 09:53:36 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160907015336.GB30281@lemon>
References: <1472063464-790-1-git-send-email-silbe@linux.vnet.ibm.com>
	<1472063464-790-2-git-send-email-silbe@linux.vnet.ibm.com>
	<20160906013045.GA653@al.usersys.redhat.com>
	<87fupchobz.fsf@oc4731375738.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <87fupchobz.fsf@oc4731375738.ibm.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large
 docker output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org

On Tue, 09/06 20:31, Sascha Silbe wrote:
> Dear Fam,
>=20
> Fam Zheng <famz@redhat.com> writes:
>=20
> > On Wed, 08/24 20:30, Sascha Silbe wrote:
> [tests/docker/docker.py]
> >> @@ -25,6 +25,10 @@ from tarfile import TarFile, TarInfo
> >>  from StringIO import StringIO
> >>  from shutil import copy, rmtree
> >> =20
> >> +
> >> +DEVNULL =3D open(os.devnull, 'wb')
> >> +
> >> +
> >
> > Too many blank lines? Otherwise looks good.
>=20
> You caught me sneaking in a PEP-8 compliance fix. ;)

Ah, no problem. I just didn't know.

>=20
> Is qemu using a custom code style for Python sources? If so, is it
> documented somewhere?

No, and following PEP-8 is completely fine.

Fam

>=20
> Thanks for reviewing!
>=20
> Sascha
> --=20
> Softwareentwicklung Sascha Silbe, Niederhofenstra=DFe 5/1, 71229 Leonbe=
rg
> https://se-silbe.de/
> USt-IdNr. DE281696641
>=20
>=20