From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhSEW-0005Y1-Nq for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:05:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhSEU-000896-I6 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:04:59 -0400 Date: Wed, 7 Sep 2016 12:03:51 +1000 From: David Gibson Message-ID: <20160907020351.GH2780@voom.fritz.box> References: <1472661255-20160-1-git-send-email-clg@kaod.org> <1472661255-20160-4-git-send-email-clg@kaod.org> <20160905033909.GA3816@voom.fritz.box> <1473059513.2313.44.camel@kernel.crashing.org> <20160906004847.GB2900@voom.fritz.box> <3af4c2d9-7263-7c54-0a12-c0b4108c65bd@kaod.org> <1473198436.8689.38.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tT3UgwmDxwvOMqfu" Content-Disposition: inline In-Reply-To: <1473198436.8689.38.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH v2 3/7] ppc/pnv: Add XSCOM infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --tT3UgwmDxwvOMqfu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 07, 2016 at 07:47:16AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-09-06 at 16:42 +0200, C=E9dric Le Goater wrote: > >=20 > > The change does seem too invasive. I can give it a try in next > > version. > >=20 > > When a memory region is triggered, the impacted device will have > > to convert the address with xscom_to_pcb_addr(). There is some=A0 > > dependency on the chip model because the translation is different.=A0 > > That would be an extra op in the xscom device model I guess.=A0 >=20 > No. If you split the XSCOM bus from the MMIO -> XSCOM bridge (the ADU) > then the conversion only happens in the former. You don't directly > route the MMIOs over ! You intercept the MMIOs and use use the > address_space_rw to "generate" the XSCOM accesses on the other side, > like I do for the LPC bus. Oh.. wait.. that is what I had in mind, I think I misinterpreted something one of you said. >=20 > We need that anyway because of the way XSCOMs can manipulate the HMER > etc... >=20 > > Also, the main purpose of the XscomBus is to loop on the devices=A0 > > to populate the device tree. I am wondering if we could just use=A0 > > a simple list under the chip for that purpose. >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --tT3UgwmDxwvOMqfu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJXz3WHAAoJEGw4ysog2bOSYFwP/0ipBZoT7PIKRhy4Pge+iyBB MEOSxixm3Igp1qJW7axB6DUxp6q2Q3+7CQLbiHYYa+atUdHPl+Oeh1glYsa/siOX rnb1Gp7pVik9VN9GsLBifNNZOW3Jp6M6to5LsebowpSpPl8HEgD40s+cUE4WbcXW tUfpm+bxYzAS6bXNpUh9CFMHkew06/30o2eQOWxYYljmvT+BXCFZ3V0woJ0thoke jAKaY/R+ODQ8Em+/hsSnqG9o36E8PCoC/V1hLe8pfzyjpS4Yy6XIQvW1BmdjDeKh +HN9FXy+U288p76+JBhX0LuxtikBx7tqkGFZjZUTTk8aTD7I07yDw563UjI2DuVm HtcSCNzBEY//Krx1CbZ2rIZnR+PQm0yIcs8nXbWhO84jBGcOAmqpPzqdGhe7x8+d Sv6TVrELLKelzl0q7UEuMMdV3ofuubcZCj5HT5RA/NWvinVr7Yjx8qejKItQVGEw ZSHTlEpIJmctviCbtrDirnrL0ySZG4GMI4LH9KMWYUpPizRWKuKx1dslXLuaKqet kl4FU3NPpwp0QFJToX/0X7NbNpOISJxxoBTJ8H7P3kfAeYjF9dBl7ZAlmxjFXiGs /kT6Vxfi+8VY1Q5N8H1RjuA5Rhy5ADtLhem7MBxFIeAPsqvaPvkl7VENKlUuGeon 2bzGJZIYsx3IKpOvnIzz =2QsT -----END PGP SIGNATURE----- --tT3UgwmDxwvOMqfu--