From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 1/3] tpm/tpm_crb: implement tpm crb idle state Date: Wed, 7 Sep 2016 16:19:08 -0600 Message-ID: <20160907221908.GA30192@obsidianresearch.com> References: <1473247953-24617-1-git-send-email-tomas.winkler@intel.com> <1473247953-24617-2-git-send-email-tomas.winkler@intel.com> <20160907161548.GA4791@obsidianresearch.com> <5B8DA87D05A7694D9FA63FD143655C1B542CBABC@hasmsx108.ger.corp.intel.com> <20160907215502.GB29666@obsidianresearch.com> <5B8DA87D05A7694D9FA63FD143655C1B542CBB41@hasmsx108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542CBB41-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Winkler, Tomas" Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Sep 07, 2016 at 10:17:22PM +0000, Winkler, Tomas wrote: > I think there is a memory leak in tpm_tis on the error path; maybe a > missing call to dev_put, not sure I had just quick look. tpmm_alloc uses devm, so the put happens in a devm cleanup. Assuming everything still works the way it was intended :/ Jason ------------------------------------------------------------------------------