From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhuvh-0002h3-AG for qemu-devel@nongnu.org; Thu, 08 Sep 2016 04:43:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhuvb-0008KD-WC for qemu-devel@nongnu.org; Thu, 08 Sep 2016 04:43:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhuvb-0008Jp-Qw for qemu-devel@nongnu.org; Thu, 08 Sep 2016 04:43:23 -0400 Date: Thu, 8 Sep 2016 10:43:19 +0200 From: Kevin Wolf Message-ID: <20160908084319.GA4206@noname.redhat.com> References: <1471935390-126476-1-git-send-email-ashish.mittal@veritas.com> <20160830173507.GA1501@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ashish mittal Cc: Jeff Cody , qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster , "Daniel P. Berrange" , Ashish Mittal , Stefan Hajnoczi , Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > >> + > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > >> +{ > >> + VXHSAIOCB *acb = ptr; > >> + > >> + acb->buffer = buffer; > >> +} > >> + > > > > Unused function? > > This is called from within libqnio. Wait, you mean the library references a symbol in the qemu binary? This sounds completely wrong to me. I wouldn't even do something like this if it were an internal qemu library because I think libraries should be self-contained, but it's a much larger problem in something that is supposed to be an independent library. If the library has to call into qemu, it should only do so through callbacks that qemu registered with the library (and then the function wouldn't look unused in qemu). In an earlier version of the series I suggested moving the part directly related to qemu (at least the functions called qemu_*) from the library to the block driver. Did you consider this? Kevin