From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 8 Sep 2016 09:15:45 -0400 Subject: [U-Boot] image-fit: switch ENOLINK to ENOENT In-Reply-To: <20160908130634.GC42608@largo.jsg.id.au> References: <20160902223014.86215-1-jsg@jsg.id.au> <20160907180019.GX4990@bill-the-cat> <20160908120152.GB42608@largo.jsg.id.au> <20160908124853.GA4990@bill-the-cat> <20160908130634.GC42608@largo.jsg.id.au> Message-ID: <20160908131545.GB4990@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Sep 08, 2016 at 11:06:34PM +1000, Jonathan Gray wrote: > On Thu, Sep 08, 2016 at 08:48:53AM -0400, Tom Rini wrote: > > On Thu, Sep 08, 2016 at 10:01:52PM +1000, Jonathan Gray wrote: > > > On Wed, Sep 07, 2016 at 02:00:19PM -0400, Tom Rini wrote: > > > > On Sat, Sep 03, 2016 at 08:30:14AM +1000, Jonathan Gray wrote: > > > > > > > > > ENOLINK is not required by POSIX and does not exist on OpenBSD > > > > > and likely other systems. > > > > > > > > > > Signed-off-by: Jonathan Gray > > > > > > > > Applied to u-boot/master, thanks! > > > > > > Thanks for applying this and the other patch. > > > > > > In tools/kwboot.c I've also locally changed EPROTO and EBADMSG as they > > > aren't on OpenBSD either. > > > > > > They are in POSIX however so I am trying to get them into OpenBSD, > > > but it will need some time to be scheduled as introducing errnos > > > involves cranking the major version of libc due to the size of the array > > > with errno strings changing. > > > > > > I wasn't sure if the following would be accepted for that reason, > > > thoughts? > > > > Well, looking over the code in question, we're talking about error > > handling during xmodem transfers. What are the errno values that get > > used there by xmodem tools? Thanks! > > I don't see how xmodem tools would use those errno values themselves? > From what I understood, kwboot attaches directly to serial /dev devices > and handles xmodem and terminal emulation itself. > > In the kwboot case nothing in the return path seems to check for > specific errno values. The return sequence looks like > > kwboot_xm_sendblock > kwboot_xmodem > main > perror("xmodem"); Right. But we're also using it to indicate to the caller that there was a problem. I can see using EIO for unknown error but I don't like ECONNREFUSED for an explicit NAK. So what I'm asking is, what's passed around in other tools when you get a NAK reply in xmodem? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: