From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 2/3] tmp/tpm_crb: fix Intel PTT hw bug during idle state Date: Thu, 8 Sep 2016 16:44:06 +0300 Message-ID: <20160908134406.GB8952@intel.com> References: <1473247953-24617-1-git-send-email-tomas.winkler@intel.com> <1473247953-24617-3-git-send-email-tomas.winkler@intel.com> <20160908111458.GE4712@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160908111458.GE4712-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Tomas Winkler Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Sep 08, 2016 at 02:14:58PM +0300, Jarkko Sakkinen wrote: > On Wed, Sep 07, 2016 at 02:32:32PM +0300, Tomas Winkler wrote: > > There is a HW bug in Skylake, Kabylake, and Broxton PCH Intel PTT device, > > where most of the registers in the control area except START, REQUEST, > > CANCEL, and LOC_CTRL lost retention when the device is in the idle state. > > Hence we need to bring the device to ready state before accessing the > > other registers. The fix brings device to ready state before trying to read > > command and response buffer addresses in order to remap the for access. > > > > Signed-off-by: Tomas Winkler > > I think I would add the dev_dbg line permanently with it that you have > in responses in this thread. There's been some unrelated bugs before > where this information in klog would have been very handy. > > Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen (with Broxton PCH) /Jarkko ------------------------------------------------------------------------------