From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi0AH-0001nR-8j for qemu-devel@nongnu.org; Thu, 08 Sep 2016 10:18:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi0AD-0000x9-23 for qemu-devel@nongnu.org; Thu, 08 Sep 2016 10:18:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi0AC-0000wq-TR for qemu-devel@nongnu.org; Thu, 08 Sep 2016 10:18:48 -0400 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Thu, 8 Sep 2016 18:17:19 +0400 Message-Id: <20160908141720.30641-25-marcandre.lureau@redhat.com> In-Reply-To: <20160908141720.30641-1-marcandre.lureau@redhat.com> References: <20160908141720.30641-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULLv2 24/25] tests: fix rsp leak in postcopy-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= In all cases, even when the dict doesn't contain 'ram', the qmp response must be unref. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Eric Blake --- tests/postcopy-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index 229e9e9..bf4e579 100644 --- a/tests/postcopy-test.c +++ b/tests/postcopy-test.c @@ -260,8 +260,8 @@ static uint64_t get_migration_pass(void) } else { rsp_ram =3D qdict_get_qdict(rsp_return, "ram"); result =3D qdict_get_try_int(rsp_ram, "dirty-sync-count", 0); - QDECREF(rsp); } + QDECREF(rsp); return result; } =20 --=20 2.10.0