All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, eblake@redhat.com, armbru@redhat.com,
	pbonzini@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULLv2 05/25] tests: fix test-cutils leaks
Date: Thu,  8 Sep 2016 18:17:00 +0400	[thread overview]
Message-ID: <20160908141720.30641-6-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20160908141720.30641-1-marcandre.lureau@redhat.com>

Spotted thanks to ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 tests/test-cutils.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/tests/test-cutils.c b/tests/test-cutils.c
index 64e3e95..20b0f59 100644
--- a/tests/test-cutils.c
+++ b/tests/test-cutils.c
@@ -378,7 +378,7 @@ static void test_qemu_strtol_hex(void)
 
 static void test_qemu_strtol_max(void)
 {
-    const char *str = g_strdup_printf("%ld", LONG_MAX);
+    char *str = g_strdup_printf("%ld", LONG_MAX);
     char f = 'X';
     const char *endptr = &f;
     long res = 999;
@@ -389,6 +389,7 @@ static void test_qemu_strtol_max(void)
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, LONG_MAX);
     g_assert(endptr == str + strlen(str));
+    g_free(str);
 }
 
 static void test_qemu_strtol_overflow(void)
@@ -497,7 +498,7 @@ static void test_qemu_strtol_full_trailing(void)
 
 static void test_qemu_strtol_full_max(void)
 {
-    const char *str = g_strdup_printf("%ld", LONG_MAX);
+    char *str = g_strdup_printf("%ld", LONG_MAX);
     long res;
     int err;
 
@@ -505,6 +506,7 @@ static void test_qemu_strtol_full_max(void)
 
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, LONG_MAX);
+    g_free(str);
 }
 
 static void test_qemu_strtoul_correct(void)
@@ -662,7 +664,7 @@ static void test_qemu_strtoul_hex(void)
 
 static void test_qemu_strtoul_max(void)
 {
-    const char *str = g_strdup_printf("%lu", ULONG_MAX);
+    char *str = g_strdup_printf("%lu", ULONG_MAX);
     char f = 'X';
     const char *endptr = &f;
     unsigned long res = 999;
@@ -673,6 +675,7 @@ static void test_qemu_strtoul_max(void)
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, ULONG_MAX);
     g_assert(endptr == str + strlen(str));
+    g_free(str);
 }
 
 static void test_qemu_strtoul_overflow(void)
@@ -776,7 +779,7 @@ static void test_qemu_strtoul_full_trailing(void)
 
 static void test_qemu_strtoul_full_max(void)
 {
-    const char *str = g_strdup_printf("%lu", ULONG_MAX);
+    char *str = g_strdup_printf("%lu", ULONG_MAX);
     unsigned long res = 999;
     int err;
 
@@ -784,6 +787,7 @@ static void test_qemu_strtoul_full_max(void)
 
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, ULONG_MAX);
+    g_free(str);
 }
 
 static void test_qemu_strtoll_correct(void)
@@ -941,7 +945,7 @@ static void test_qemu_strtoll_hex(void)
 
 static void test_qemu_strtoll_max(void)
 {
-    const char *str = g_strdup_printf("%lld", LLONG_MAX);
+    char *str = g_strdup_printf("%lld", LLONG_MAX);
     char f = 'X';
     const char *endptr = &f;
     int64_t res = 999;
@@ -952,6 +956,7 @@ static void test_qemu_strtoll_max(void)
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, LLONG_MAX);
     g_assert(endptr == str + strlen(str));
+    g_free(str);
 }
 
 static void test_qemu_strtoll_overflow(void)
@@ -1058,7 +1063,7 @@ static void test_qemu_strtoll_full_trailing(void)
 static void test_qemu_strtoll_full_max(void)
 {
 
-    const char *str = g_strdup_printf("%lld", LLONG_MAX);
+    char *str = g_strdup_printf("%lld", LLONG_MAX);
     int64_t res;
     int err;
 
@@ -1066,6 +1071,7 @@ static void test_qemu_strtoll_full_max(void)
 
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, LLONG_MAX);
+    g_free(str);
 }
 
 static void test_qemu_strtoull_correct(void)
@@ -1223,7 +1229,7 @@ static void test_qemu_strtoull_hex(void)
 
 static void test_qemu_strtoull_max(void)
 {
-    const char *str = g_strdup_printf("%llu", ULLONG_MAX);
+    char *str = g_strdup_printf("%llu", ULLONG_MAX);
     char f = 'X';
     const char *endptr = &f;
     uint64_t res = 999;
@@ -1234,6 +1240,7 @@ static void test_qemu_strtoull_max(void)
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, ULLONG_MAX);
     g_assert(endptr == str + strlen(str));
+    g_free(str);
 }
 
 static void test_qemu_strtoull_overflow(void)
@@ -1339,7 +1346,7 @@ static void test_qemu_strtoull_full_trailing(void)
 
 static void test_qemu_strtoull_full_max(void)
 {
-    const char *str = g_strdup_printf("%lld", ULLONG_MAX);
+    char *str = g_strdup_printf("%lld", ULLONG_MAX);
     uint64_t res = 999;
     int err;
 
@@ -1347,6 +1354,7 @@ static void test_qemu_strtoull_full_max(void)
 
     g_assert_cmpint(err, ==, 0);
     g_assert_cmpint(res, ==, ULLONG_MAX);
+    g_free(str);
 }
 
 static void test_qemu_strtosz_simple(void)
-- 
2.10.0

  parent reply	other threads:[~2016-09-08 14:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 14:16 [Qemu-devel] [PULLv2 00/25] Leak patches Marc-André Lureau
2016-09-08 14:16 ` [Qemu-devel] [PULLv2 01/25] tests: fix test-qga leaks Marc-André Lureau
2016-09-08 14:16 ` [Qemu-devel] [PULLv2 02/25] glib-compat: add g_(s)list_free_full() Marc-André Lureau
2016-09-08 14:16 ` [Qemu-devel] [PULLv2 03/25] qga: free the whole blacklist Marc-André Lureau
2016-09-08 14:16 ` [Qemu-devel] [PULLv2 04/25] qga: free remaining leaking state Marc-André Lureau
2016-09-08 14:17 ` Marc-André Lureau [this message]
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 06/25] tests: fix test-vmstate leaks Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 07/25] tests: fix test-iov leaks Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 08/25] tests: fix check-qom-interface leaks Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 09/25] tests: fix check-qom-proplist leaks Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 10/25] tests: fix leak in test-string-input-visitor Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 11/25] portio: keep references on portio Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 12/25] pc: simplify passing qemu_irq Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 13/25] pc: don't leak a20_line Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 14/25] machine: use class base init generated name Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 15/25] acpi-build: fix array leak Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 16/25] tests: fix qom-test leaks Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 17/25] pc: free i8259 Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 18/25] pc: keep gsi reference Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 19/25] sd: free timer Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 20/25] ipmi: free extern timer Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 21/25] bus: simplify name handling Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 22/25] tests: add qtest_add_data_func_full Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 23/25] tests: pc-cpu-test leaks fixes Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 24/25] tests: fix rsp leak in postcopy-test Marc-André Lureau
2016-09-08 14:17 ` [Qemu-devel] [PULLv2 25/25] tests: fix postcopy-test leaks Marc-André Lureau
2016-09-09 10:07 ` [Qemu-devel] [PULLv2 00/25] Leak patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160908141720.30641-6-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.