From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965873AbcIHOzo (ORCPT ); Thu, 8 Sep 2016 10:55:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:41753 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932500AbcIHOzn (ORCPT ); Thu, 8 Sep 2016 10:55:43 -0400 Date: Thu, 8 Sep 2016 16:55:41 +0200 From: "Luis R. Rodriguez" To: Daniel Wagner Cc: "Luis R. Rodriguez" , Daniel Wagner , linux-kernel@vger.kernel.org, Ming Lei , Greg Kroah-Hartman , "Srivatsa S. Bhat" , "Rafael J. Wysocki" Subject: Re: [PATCH v4 1/4] firmware: Move umh locking code into fw_load_from_user_helper() Message-ID: <20160908145541.GF3296@wotan.suse.de> References: <1473237908-20989-1-git-send-email-wagi@monom.org> <1473237908-20989-2-git-send-email-wagi@monom.org> <20160907233306.GZ3296@wotan.suse.de> <509a727e-e784-8e6f-c112-760a0f8493b6@bmw-carit.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <509a727e-e784-8e6f-c112-760a0f8493b6@bmw-carit.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2016 at 02:41:33PM +0200, Daniel Wagner wrote: > So far I have it tested with kvm. I'll give it a spin on real > hardware. Good point. If you can also include testing with the test_firmware.ko driver and describe your tests in the cover letter that would be appreciated. Bonus points if you also indicate you've had 0-day have full success with your delta. To do that just poke Fenguang that you need testing for a branch, and then push to your branch. I noted I gave your changes a test spin and it came back OK, so it should be good, but still, this is rather good practice for any changes sent out. Luis