From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v4 10/26] drm/i915/slpc:
 Allocate/Release/Initialize SLPC shared data
Date: Fri, 9 Sep 2016 18:08:46 +0100
Message-ID: <20160909170846.GL20027@nuc-i3427.alporthouse.com>
References: <1473425505-3890-1-git-send-email-sagar.a.kamble@intel.com>
 <1473425505-3890-11-git-send-email-sagar.a.kamble@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E7A516E933
 for <intel-gfx@lists.freedesktop.org>; Fri,  9 Sep 2016 17:08:54 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1473425505-3890-11-git-send-email-sagar.a.kamble@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Tom O'Rourke <Tom.O'Rourke@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBTZXAgMDksIDIwMTYgYXQgMDY6MjE6MjlQTSArMDUzMCwgU2FnYXIgQXJ1biBLYW1i
bGUgd3JvdGU6Cj4gRnJvbTogVG9tIE8nUm91cmtlIDxUb20uTydSb3Vya2VAaW50ZWwuY29tPgo+
IAo+IFNMUEMgc2hhcmVkIGRhdGEgaXMgdXNlZCB0byBwYXNzIGluZm9ybWF0aW9uCj4gdG8vZnJv
bSBTTFBDIGluIEd1QyBmaXJtd2FyZS4KPiAKPiBGb3IgU2t5bGFrZSwgcGxhdGZvcm0gc2t1IHR5
cGUgYW5kIHNsaWNlIGNvdW50Cj4gYXJlIGlkZW50aWZpZWQgZnJvbSBkZXZpY2UgaWQgYW5kIGZ1
c2UgdmFsdWVzLgo+IAo+IFN1cHBvcnQgZm9yIG90aGVyIHBsYXRmb3JtcyBuZWVkcyB0byBiZSBh
ZGRlZC4KPiAKPiB2MTogVXBkYXRlIGZvciBTTFBDIGludGVyZmFjZSB2ZXJzaW9uIDIwMTUuMi40
Cj4gICAgIGludGVsX3NscGNfYWN0aXZlKCkgcmV0dXJucyAxIGlmIHNscGMgaW5pdGlhbGl6ZWQg
KFBhdWxvKQo+ICAgICBjaGFuZ2UgZGVmYXVsdCBob3N0X29zIHRvICJXaW5kb3dzIgo+ICAgICBT
cGVsbGluZyBmaXhlcyAoU2FnYXIgS2FtYmxlIGFuZCBOaWNrIEhvYXRoKQo+ICAgICBBZGRlZCBX
QVJOIGZvciBjaGVja2luZyBpZiB1cHBlciAzMmJpdHMgb2YgR1RUIG9mZnNldAo+ICAgICBvZiBz
aGFyZWQgb2JqZWN0IGFyZSB6ZXJvLiAoQ2hyaXNXKQo+ICAgICBDaGFuZ2VkIGZ1bmN0aW9uIGNh
bGwgZnJvbSBnZW1fYWxsb2NhdGUvcmVsZWFzZV9ndWNfb2JqIHRvCj4gICAgIGk5MTVfZ3VjX2Fs
bG9jYXRlL3JlbGVhc2VfZ2VtX29iai4gKFNhZ2FyKQo+ICAgICBVcGRhdGVkIGNvbW1pdCBtZXNz
YWdlIGFuZCBtb3ZlZCBQT1dFUl9QTEFOIGFuZCBQT1dFUl9TT1VSQ0UKPiAgICAgZGVmaW5pdGlv
biBmcm9tIGxhdGVyIHBhdGNoLiAoQWthc2gpCj4gICAgIEFkZCBzdHJ1Y3RfbXV0ZXggbG9ja2lu
ZyB3aGlsZSBhbGxvY2F0aW5nL3JlbGVhc2luZyBzbHBjIHNoYXJlZAo+ICAgICBvYmplY3QuIFRo
aXMgd2FzIGNhdWdodCBieSBDSSBCQVQuIEFkZGluZyBTTFBDIHN0YXRlIHZhcmlhYmxlCj4gICAg
IHRvIGRldGVybWluZSBpZiBpdCBpcyBhY3RpdmUgYXMgaXQgbm90IGp1c3QgZGVwZW5kZW50IG9u
IHNoYXJlZAo+ICAgICBkYXRhIHNldHVwLgo+ICAgICBSZWJhc2Ugd2l0aCBndWNfYWxsb2NhdGVf
dm1hIHJlbGF0ZWQgY2hhbmdlcy4KPiAKPiB2MjogV0FSTl9PTiBmb3IgcGxhdGZvcm1fc2t1IHZh
bGlkaXR5IGFuZCBzcGFjZSBjaGFuZ2VzLiAoRGF2aWQpCj4gICAgIENoZWNrcGF0Y2ggdXBkYXRl
Lgo+IAo+IHYzOiBGaXhpbmcgV0FSTklORyBpbiBpZ3RAZHJ2X21vZHVsZV9yZWxvYWRfYmFzaWMg
Zm91bmQgaW4gdHJ5Ym90IEJBVAo+ICAgICB3aXRoIFNMUEMgRW5hYmxlZC4KPiAKPiB2NDogVXBk
YXRlZCBzdXBwb3J0IGZvciBHdUMgdjkuIHMvc2xpY2VfdG90YWwvaHdlaWdodDgoc2xpY2VfbWFz
aykvIChEYXZlKS4KPiAKPiBSZXZpZXdlZC1ieTogRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWlu
ZWhhbGxAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFRvbSBPJ1JvdXJrZSA8VG9t
Lk8nUm91cmtlQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTYWdhciBBcnVuIEthbWJsZSA8
c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcnYuaCAgfCAgNyArKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgg
IHwgIDIgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jICAgfCAgNiArKy0KPiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2xwYy5jIHwgODggKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zbHBjLmggfCA5
OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgNSBmaWxlcyBjaGFu
Z2VkLCAxOTkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcnYuaAo+IGluZGV4IGNmOWFhMjQuLjc5NmM1MmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcnYuaAo+IEBAIC0xNzA3LDcgKzE3MDcsMTIgQEAgYm9vbCBjaHZfcGh5X3Bvd2VyZ2F0
ZV9jaChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gZHBpb19waHkgcGh5
LAo+ICAKCkkgYW0gZ29pbmcgdG8gbmVlZCBhbiBpZGlvdCdzIGd1aWRlIGhlcmUgYXMgdG8gdGhl
IGRpZmZlcmVuY2UgYmV0d2VlbgplbmFibGVkKCkgYW5kIGFjdGl2ZSgpLgoKPiAgc3RhdGljIGlu
bGluZSBpbnQgaW50ZWxfc2xwY19hY3RpdmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2KQoKYm9vbC4KCj4gIHsKPiAtCXJldHVybiAwOwo+ICsJaW50IHJldCA9IDA7Cj4gKwo+ICsJ
aWYgKGRldl9wcml2LT5ndWMuc2xwYy52bWEgJiYgZGV2X3ByaXYtPmd1Yy5zbHBjLmVuYWJsZWQp
Cj4gKwkJcmV0ID0gMTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICAvKiBpbnRlbF9w
bS5jICovCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBpbmRleCA4M2RlYzY2Li42ZTI0ZTYw
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBAQCAtMTQ1LDYgKzE0NSw4IEBAIHN0
cnVjdCBpbnRlbF9ndWMgewo+ICAKPiAgCXVpbnQ2NF90IHN1Ym1pc3Npb25zW0k5MTVfTlVNX0VO
R0lORVNdOwo+ICAJdWludDMyX3QgbGFzdF9zZXFub1tJOTE1X05VTV9FTkdJTkVTXTsKPiArCj4g
KwlzdHJ1Y3QgaW50ZWxfc2xwYyBzbHBjOwo+ICB9Owo+ICAKPiAgc3RhdGljIGlubGluZSBpbnQg
aW50ZWxfc2xwY19lbmFibGVkKHZvaWQpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXgg
ZDE4NzA2Ni4uMjIxMWY3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC02NjU2
LDcgKzY2NTYsOCBAQCB2b2lkIGludGVsX2luaXRfZ3RfcG93ZXJzYXZlKHN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIHZvaWQgaW50ZWxfY2xlYW51cF9ndF9wb3dlcnNh
dmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlpZiAoaW50ZWxf
c2xwY19lbmFibGVkKCkpCj4gKwlpZiAoaW50ZWxfc2xwY19lbmFibGVkKCkgJiYKPiArCSAgICBk
ZXZfcHJpdi0+Z3VjLnNscGMudm1hKQo+ICAJCWludGVsX3NscGNfY2xlYW51cChkZXZfcHJpdik7
Cj4gIAllbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSkKPiAgCQl2YWxsZXl2aWV3X2Ns
ZWFudXBfZ3RfcG93ZXJzYXZlKGRldl9wcml2KTsKPiBAQCAtNjc0Niw3ICs2NzQ3LDggQEAgdm9p
ZCBpbnRlbF9lbmFibGVfZ3RfcG93ZXJzYXZlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdikKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ICAKPiAt
CWlmIChpbnRlbF9zbHBjX2VuYWJsZWQoKSkgewo+ICsJaWYgKGludGVsX3NscGNfZW5hYmxlZCgp
ICYmCj4gKwkgICAgZGV2X3ByaXYtPmd1Yy5zbHBjLnZtYSkgewo+ICAJCWdlbjlfZW5hYmxlX3Jj
NihkZXZfcHJpdik7Cj4gIAkJaW50ZWxfc2xwY19lbmFibGUoZGV2X3ByaXYpOwo+ICAJCWlmIChJ
U19TS1lMQUtFKGRldl9wcml2KSB8fCBJU19LQUJZTEFLRShkZXZfcHJpdikpCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NscGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3NscGMuYwo+IGluZGV4IGJlOWU4NGMuLjk3MmRiMTggMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2xwYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfc2xwYy5jCj4gQEAgLTIyLDE1ICsyMiwxMDMgQEAKPiAgICoKPiAgICovCj4g
ICNpbmNsdWRlIDxsaW51eC9maXJtd2FyZS5oPgo+ICsjaW5jbHVkZSA8YXNtL21zci1pbmRleC5o
Pgo+ICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiAgI2luY2x1ZGUgImludGVsX2d1Yy5oIgo+ICAK
PiArc3RhdGljIHVuc2lnbmVkIGludCBzbHBjX2dldF9wbGF0Zm9ybV9za3Uoc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwllbnVtIHNscGNfcGxhdGZvcm1fc2t1IHBs
YXRmb3JtX3NrdTsKPiArCj4gKwlpZiAoSVNfU0tMX1VMWChkZXZfcHJpdikpCj4gKwkJcGxhdGZv
cm1fc2t1ID0gU0xQQ19QTEFURk9STV9TS1VfVUxYOwo+ICsJZWxzZSBpZiAoSVNfU0tMX1VMVChk
ZXZfcHJpdikpCj4gKwkJcGxhdGZvcm1fc2t1ID0gU0xQQ19QTEFURk9STV9TS1VfVUxUOwo+ICsJ
ZWxzZQo+ICsJCXBsYXRmb3JtX3NrdSA9IFNMUENfUExBVEZPUk1fU0tVX0RUOwo+ICsKPiArCVdB
Uk5fT04ocGxhdGZvcm1fc2t1ID4gMHhGRik7Cj4gKwo+ICsJcmV0dXJuIHBsYXRmb3JtX3NrdTsK
PiArfQo+ICsKPiArc3RhdGljIHVuc2lnbmVkIGludCBzbHBjX2dldF9zbGljZV9jb3VudChzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCXVuc2lnbmVkIGludCBzbGlj
ZV9jb3VudCA9IDE7Cj4gKwo+ICsJaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpKQo+ICsJCXNsaWNl
X2NvdW50ID0gaHdlaWdodDgoSU5URUxfSU5GTyhkZXZfcHJpdiktPnNzZXUuc2xpY2VfbWFzayk7
Cj4gKwo+ICsJcmV0dXJuIHNsaWNlX2NvdW50Owo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBzbHBj
X3NoYXJlZF9kYXRhX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7
Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICsJc3RydWN0IHBhZ2UgKnBh
Z2U7Cj4gKwlzdHJ1Y3Qgc2xwY19zaGFyZWRfZGF0YSAqZGF0YTsKPiArCXU2NCBtc3JfdmFsdWU7
Cj4gKwo+ICsJaWYgKCFkZXZfcHJpdi0+Z3VjLnNscGMudm1hKQo+ICsJCXJldHVybjsKPiArCj4g
KwlvYmogPSBkZXZfcHJpdi0+Z3VjLnNscGMudm1hLT5vYmo7Cj4gKwo+ICsJcGFnZSA9IGk5MTVf
Z2VtX29iamVjdF9nZXRfcGFnZShvYmosIDApOwoKcGFnZSA9IGk5MTVfdm1hX2ZpcnN0X3BnYWUo
ZGV2X3ByaXYtPmd1Yy5zbHBjLnZtYSk7CgphbmQgY2Fubm90IGJlIE5VTEwgKGJ5IGNvbnN0cnVj
dGlvbiBpbiBndWNfYWxsb2NhdGVfdm1hKS4KCj4gKwlpZiAocGFnZSkgewo+ICsJCWRhdGEgPSBr
bWFwX2F0b21pYyhwYWdlKTsKPiArCQltZW1zZXQoZGF0YSwgMCwgc2l6ZW9mKHN0cnVjdCBzbHBj
X3NoYXJlZF9kYXRhKSk7Cj4gKwo+ICsJCWRhdGEtPnNoYXJlZF9kYXRhX3NpemUgPSBzaXplb2Yo
c3RydWN0IHNscGNfc2hhcmVkX2RhdGEpOwo+ICsJCWRhdGEtPmdsb2JhbF9zdGF0ZSA9ICh1MzIp
U0xQQ19HTE9CQUxfU1RBVEVfTk9UX1JVTk5JTkc7Cj4gKwkJZGF0YS0+cGxhdGZvcm1faW5mby5w
bGF0Zm9ybV9za3UgPQo+ICsJCQkJCSh1OClzbHBjX2dldF9wbGF0Zm9ybV9za3UoZGV2X3ByaXYp
Owo+ICsJCWRhdGEtPnBsYXRmb3JtX2luZm8uc2xpY2VfY291bnQgPQo+ICsJCQkJCSh1OClzbHBj
X2dldF9zbGljZV9jb3VudChkZXZfcHJpdik7Cj4gKwkJZGF0YS0+cGxhdGZvcm1faW5mby5wb3dl
cl9wbGFuX3NvdXJjZSA9Cj4gKwkJCSh1OClTTFBDX1BPV0VSX1BMQU5fU09VUkNFKFNMUENfUE9X
RVJfUExBTl9CQUxBTkNFRCwKPiArCQkJCQkJICAgIFNMUENfUE9XRVJfU09VUkNFX0FDKTsKPiAr
CQlyZG1zcmwoTVNSX1RVUkJPX1JBVElPX0xJTUlULCBtc3JfdmFsdWUpOwo+ICsJCWRhdGEtPnBs
YXRmb3JtX2luZm8uUDBfZnJlcSA9ICh1OCltc3JfdmFsdWU7Cj4gKwkJcmRtc3JsKE1TUl9QTEFU
Rk9STV9JTkZPLCBtc3JfdmFsdWUpOwo+ICsJCWRhdGEtPnBsYXRmb3JtX2luZm8uUDFfZnJlcSA9
ICh1OCkobXNyX3ZhbHVlID4+IDgpOwo+ICsJCWRhdGEtPnBsYXRmb3JtX2luZm8uUGVfZnJlcSA9
ICh1OCkobXNyX3ZhbHVlID4+IDQwKTsKPiArCQlkYXRhLT5wbGF0Zm9ybV9pbmZvLlBuX2ZyZXEg
PSAodTgpKG1zcl92YWx1ZSA+PiA0OCk7CgpUaGUgdTggZXQgYWwgYXJlIGltcGxpZWQgYW55d2F5
LCBhcmUgdGhleSBub3Q/Cgo+ICsKPiArCQlrdW5tYXBfYXRvbWljKGRhdGEpOwo+ICsJfQo+ICt9
Cj4gKwo+ICB2b2lkIGludGVsX3NscGNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYpCj4gIHsKPiArCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZfcHJpdi0+Z3VjOwo+
ICsJc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gKwo+ICsJLyogQWxsb2NhdGUgc2hhcmVkIGRhdGEg
c3RydWN0dXJlICovCj4gKwl2bWEgPSBkZXZfcHJpdi0+Z3VjLnNscGMudm1hOwo+ICsJaWYgKCF2
bWEpIHsKClRoZXJlJ3MgYWx3YXlzIHNvbWV0aGluZyBmaXNoeSBhYm91dCBpbml0IHJvdXRpbmVz
IGNhbGxlZCBtdWx0aXBsZQp0aW1lcy4KLUNocmlzCgotLSAKQ2hyaXMgV2lsc29uLCBJbnRlbCBP
cGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK