From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v4 11/26] drm/i915/slpc: Update
 sysfs/debugfs interfaces for frequency parameters
Date: Fri, 9 Sep 2016 18:13:02 +0100
Message-ID: <20160909171302.GM20027@nuc-i3427.alporthouse.com>
References: <1473425505-3890-1-git-send-email-sagar.a.kamble@intel.com>
 <1473425505-3890-12-git-send-email-sagar.a.kamble@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 656806E940
 for <intel-gfx@lists.freedesktop.org>; Fri,  9 Sep 2016 17:13:08 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1473425505-3890-12-git-send-email-sagar.a.kamble@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Tom O'Rourke <Tom.O'Rourke@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBTZXAgMDksIDIwMTYgYXQgMDY6MjE6MzBQTSArMDUzMCwgU2FnYXIgQXJ1biBLYW1i
bGUgd3JvdGU6Cj4gRnJvbTogVG9tIE8nUm91cmtlIDxUb20uTydSb3Vya2VAaW50ZWwuY29tPgo+
IAo+IFdoZW4gU0xQQyBpcyBjb250cm9sbGluZyByZXF1ZXN0ZWQgZnJlcXVlbmN5LCB0aGUgcnBz
LmN1cl9mcmVxCj4gdmFsdWUgaXMgbm90IHVzZWQgdG8gbWFrZSB0aGUgZnJlcXVlbmN5IHJlcXVl
c3QuCj4gCj4gUmVxdWVzdGVkIGZyZXF1ZW5jeSBmcm9tIHJlZ2lzdGVyIFJQTlNXUkVRIGhhcyB0
aGUgdmFsdWUKPiBtb3N0IHJlY2VudGx5IHJlcXVlc3RlZCBieSBTTFBDIGZpcm13YXJlLiBBZGRp
bmcgbmV3IHN5c2ZzCj4gaW50ZXJmYWNlIGd0X3JlcV9mcmVxX21oeiB0byBrbm93IHRoaXMgdmFs
dWUuCj4gU0xQQyByZXF1ZXN0ZWQgdmFsdWUgbmVlZHMgdG8gYmUgbWFkZSBhdmFpbGFibGUgdG8g
aTkxNSB3aXRob3V0Cj4gcmVhZGluZyBSUE5TV1JFUS4KPiAKPiB2MTogUmVwbGFjZSBIQVNfU0xQ
QyB3aXRoIGludGVsX3NscGNfYWN0aXZlIChQYXVsbykKPiAgICAgQXZvaWQgbWFnaWMgbnVtYmVy
cyAoTmljaykKPiAgICAgVXNlIGEgZnVuY3Rpb24gZm9yIHJlcGVhdGVkIGNvZGUgKEpvbikKPiAK
PiB2MjogQWRkICJTTFBDIEFjdGl2ZSIgdG8gaTkxNV9mcmVxdWVuY3lfaW5mbyBvdXRwdXQgYW5k
Cj4gICAgIGRvbid0IHVwZGF0ZSBjdXJfZnJlcSBhcyBpdCBpcyBkcml2ZXIgaW50ZXJuYWwgcmVx
dWVzdC4gKENocmlzKQo+IAo+IHYzOiBSZW1vdmluZyBzeXNmcyBpbnRlcmZhY2UgZ3RfcmVxX2Zy
ZXFfbWh6IG91dCBvZiB0aGlzIHBhdGNoCj4gICAgIGZvciBwcm9wZXIgZGl2aXNpb24gb2YgZnVu
Y3Rpb25hbGl0eS4gKFNhZ2FyKQo+IAo+IHY0OiBpZGxlX2ZyZXEsIGJvb3N0X2ZyZXEgYXJlIGFs
c28gbm90IHVzZWQgd2l0aCBTTFBDLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRvbSBPJ1JvdXJrZSA8
VG9tLk8nUm91cmtlQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTYWdhciBBcnVuIEthbWJs
ZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2RlYnVnZnMuYyB8IDI0ICsrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMgICB8ICAzICsrKwo+ICAyIGZpbGVzIGNoYW5nZWQs
IDIxIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9kZWJ1Z2ZzLmMKPiBpbmRleCAwMmI2MjdlLi43MWJjZTMyIDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMTA4Myw2ICsxMDgzLDkgQEAgc3RhdGljIGludCBpOTE1
X2ZyZXF1ZW5jeV9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqdW51c2VkKQo+ICAKPiAg
CWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPiAgCj4gKwlpZiAoaW50ZWxfc2xwY19h
Y3RpdmUoZGV2X3ByaXYpKQo+ICsJCXNlcV9wdXRzKG0sICJTTFBDIEFjdGl2ZVxuIik7Cj4gKwo+
ICAJaWYgKElTX0dFTjUoZGV2X3ByaXYpKSB7Cj4gIAkJdTE2IHJndnN3Y3RsID0gSTkxNV9SRUFE
MTYoTUVNU1dDVEwpOwo+ICAJCXUxNiByZ3ZzdGF0ID0gSTkxNV9SRUFEMTYoTUVNU1RBVF9JTEsp
Owo+IEBAIC0xMjUwLDE1ICsxMjUzLDIxIEBAIHN0YXRpYyBpbnQgaTkxNV9mcmVxdWVuY3lfaW5m
byhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnVudXNlZCkKPiAgCQlzZXFfcHJpbnRmKG0sICJN
YXggb3ZlcmNsb2NrZWQgZnJlcXVlbmN5OiAlZE1IelxuIiwKPiAgCQkJICAgaW50ZWxfZ3B1X2Zy
ZXEoZGV2X3ByaXYsIGRldl9wcml2LT5ycHMubWF4X2ZyZXEpKTsKPiAgCj4gLQkJc2VxX3ByaW50
ZihtLCAiQ3VycmVudCBmcmVxOiAlZCBNSHpcbiIsCj4gLQkJCSAgIGludGVsX2dwdV9mcmVxKGRl
dl9wcml2LCBkZXZfcHJpdi0+cnBzLmN1cl9mcmVxKSk7Cj4gKwkJaWYgKCFpbnRlbF9zbHBjX2Fj
dGl2ZShkZXZfcHJpdikpIHsKCkp1c3Qga2VlcCBwcmludGluZyB0aGVtLCB3ZSBoYXZlIHRoZSBi
YW5uZXIgdXBmcm9udCwgYW5kIGJlaW5nIGFibGUgdG8KdHJhY2sgYW5kIGNvbXBhcmUgaW50ZXJu
YWwgdmFsdWVzIHZzIGh3IHN0YXRlIGlzIHN0aWxsIGltcG9ydGFudC4gKEFuZAp0aGUgb3JkZXJp
bmcgd2FzIGZhaXJseSBpbnRlbnRpb25hbC4pCgo+ICsJCQlzZXFfcHJpbnRmKG0sICJDdXJyZW50
IGZyZXE6ICVkIE1IelxuIiwKPiArCQkJCSAgIGludGVsX2dwdV9mcmVxKGRldl9wcml2LAo+ICsJ
CQkJCQkgIGRldl9wcml2LT5ycHMuY3VyX2ZyZXEpKTsKPiArCQkJc2VxX3ByaW50ZihtLCAiSWRs
ZSBmcmVxOiAlZCBNSHpcbiIsCj4gKwkJCQkgICBpbnRlbF9ncHVfZnJlcShkZXZfcHJpdiwKPiAr
CQkJCQkJICBkZXZfcHJpdi0+cnBzLmlkbGVfZnJlcSkpOwo+ICsJCQlzZXFfcHJpbnRmKG0sICJC
b29zdCBmcmVxOiAlZCBNSHpcbiIsCj4gKwkJCQkgICBpbnRlbF9ncHVfZnJlcShkZXZfcHJpdiwK
PiArCQkJCQkJICBkZXZfcHJpdi0+cnBzLmJvb3N0X2ZyZXEpKTsKPiArCQl9Cj4gKwo+ICAJCXNl
cV9wcmludGYobSwgIkFjdHVhbCBmcmVxOiAlZCBNSHpcbiIsIGNhZ2YpOwo+IC0JCXNlcV9wcmlu
dGYobSwgIklkbGUgZnJlcTogJWQgTUh6XG4iLAo+IC0JCQkgICBpbnRlbF9ncHVfZnJlcShkZXZf
cHJpdiwgZGV2X3ByaXYtPnJwcy5pZGxlX2ZyZXEpKTsKPiAgCQlzZXFfcHJpbnRmKG0sICJNaW4g
ZnJlcTogJWQgTUh6XG4iLAo+ICAJCQkgICBpbnRlbF9ncHVfZnJlcShkZXZfcHJpdiwgZGV2X3By
aXYtPnJwcy5taW5fZnJlcSkpOwo+IC0JCXNlcV9wcmludGYobSwgIkJvb3N0IGZyZXE6ICVkIE1I
elxuIiwKPiAtCQkJICAgaW50ZWxfZ3B1X2ZyZXEoZGV2X3ByaXYsIGRldl9wcml2LT5ycHMuYm9v
c3RfZnJlcSkpOwo+ICAJCXNlcV9wcmludGYobSwgIk1heCBmcmVxOiAlZCBNSHpcbiIsCj4gIAkJ
CSAgIGludGVsX2dwdV9mcmVxKGRldl9wcml2LCBkZXZfcHJpdi0+cnBzLm1heF9mcmVxKSk7Cj4g
IAkJc2VxX3ByaW50ZihtLAo+IEBAIC0yMzE1LDYgKzIzMjQsOSBAQCBzdGF0aWMgaW50IGk5MTVf
cnBzX2Jvb3N0X2luZm8oc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAJc3RydWN0
IGRybV9kZXZpY2UgKmRldiA9ICZkZXZfcHJpdi0+ZHJtOwo+ICAJc3RydWN0IGRybV9maWxlICpm
aWxlOwo+ICAKPiArCWlmIChpbnRlbF9zbHBjX2FjdGl2ZShkZXZfcHJpdikpCj4gKwkJcmV0dXJu
IC1FTk9ERVY7Cj4gKwo+ICAJc2VxX3ByaW50ZihtLCAiUlBTIGVuYWJsZWQ/ICVkXG4iLCBkZXZf
cHJpdi0+cnBzLmVuYWJsZWQpOwo+ICAJc2VxX3ByaW50ZihtLCAiR1BVIGJ1c3k/ICVzIFsleF1c
biIsCj4gIAkJICAgeWVzbm8oZGV2X3ByaXYtPmd0LmF3YWtlKSwgZGV2X3ByaXYtPmd0LmFjdGl2
ZV9lbmdpbmVzKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNm
cy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNmcy5jCj4gaW5kZXggMTAxMmVlZS4u
MDIwZDY0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMK
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMKPiBAQCAtMjk5LDYgKzI5
OSw5IEBAIHN0YXRpYyBzc2l6ZV90IGd0X2N1cl9mcmVxX21oel9zaG93KHN0cnVjdCBkZXZpY2Ug
KmtkZXYsCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGtkZXZf
bWlub3JfdG9faTkxNShrZGV2KTsKPiAgCj4gKwlpZiAoaW50ZWxfc2xwY19hY3RpdmUoZGV2X3By
aXYpKQo+ICsJCXJldHVybiAtRU5PREVWOwoKT2ssIEkgaGFkIGEgdGhvdWdodCB0aGF0IHdlIGFs
bG93ZWQgdGhlIHVzZXIgdG8gZGlyZWN0bHkgc2V0IGN1ciBmcmVxLApidXQgd2UgZG9uJ3QuCi1D
aHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50
cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==