From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller Date: Sat, 10 Sep 2016 18:14:42 +0200 Message-ID: <20160910161442.GC29259@lst.de> References: <1472632647-1525-1-git-send-email-pandit.parav@gmail.com> <1472632647-1525-2-git-send-email-pandit.parav@gmail.com> <61101e8b-5776-c0bc-b3ea-d8b984eebabf@mellanox.com> <20160831211618.GA12660@htj.duckdns.org> <9b6a346d-af4c-1e5f-0144-f68fb8e46c27@mellanox.com> <20160901084406.GA4115@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matan Barak Cc: Parav Pandit , Christoph Hellwig , Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Li Zefan , Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Haggai Eran , Jonathan Corbet , james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, Or Gerlitz , Andrew Morton , linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Sep 07, 2016 at 11:51:42AM +0300, Matan Barak wrote: > All recent proposals of the new ABI schema deals with extending the > flexibility of the current schema by letting drivers define their specific > types, actions, attributes, etc. Even more than that, the dispatching > starts from the driver and it chooses if it wants to use the common RDMA > core layer or have it's own wise implementation instead. > Some drivers might even prefer not to implement the current verbs types. > These decisions were made in the OFVWG meetings. OFVWG meetings have absolutely zero relevance for Linux development. More "flexibility" for drivers just means giving up on designing a coherent API and leaving it to drivers authors to add crap to their own drivers. That's a major step backwards. > Sounds reasonable, but what about drivers which ignore the common code and > implement it in their own way? What about drivers which don't support the > standard RDMA types at all? They should not be using the code in drivers/infiniband. usnic is such an example of a driver that should never have been added in it's current form. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755831AbcIJQOs (ORCPT ); Sat, 10 Sep 2016 12:14:48 -0400 Received: from verein.lst.de ([213.95.11.211]:60011 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755145AbcIJQOp (ORCPT ); Sat, 10 Sep 2016 12:14:45 -0400 Date: Sat, 10 Sep 2016 18:14:42 +0200 From: Christoph Hellwig To: Matan Barak Cc: Parav Pandit , Christoph Hellwig , Tejun Heo , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, Linux Kernel Mailing List , linux-rdma@vger.kernel.org, Li Zefan , Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Haggai Eran , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Andrew Morton , linux-security-module@vger.kernel.org Subject: Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller Message-ID: <20160910161442.GC29259@lst.de> References: <1472632647-1525-1-git-send-email-pandit.parav@gmail.com> <1472632647-1525-2-git-send-email-pandit.parav@gmail.com> <61101e8b-5776-c0bc-b3ea-d8b984eebabf@mellanox.com> <20160831211618.GA12660@htj.duckdns.org> <9b6a346d-af4c-1e5f-0144-f68fb8e46c27@mellanox.com> <20160901084406.GA4115@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07, 2016 at 11:51:42AM +0300, Matan Barak wrote: > All recent proposals of the new ABI schema deals with extending the > flexibility of the current schema by letting drivers define their specific > types, actions, attributes, etc. Even more than that, the dispatching > starts from the driver and it chooses if it wants to use the common RDMA > core layer or have it's own wise implementation instead. > Some drivers might even prefer not to implement the current verbs types. > These decisions were made in the OFVWG meetings. OFVWG meetings have absolutely zero relevance for Linux development. More "flexibility" for drivers just means giving up on designing a coherent API and leaving it to drivers authors to add crap to their own drivers. That's a major step backwards. > Sounds reasonable, but what about drivers which ignore the common code and > implement it in their own way? What about drivers which don't support the > standard RDMA types at all? They should not be using the code in drivers/infiniband. usnic is such an example of a driver that should never have been added in it's current form.