From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932385AbcIKVPv (ORCPT ); Sun, 11 Sep 2016 17:15:51 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:57914 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205AbcIKVPs (ORCPT ); Sun, 11 Sep 2016 17:15:48 -0400 Date: Sun, 11 Sep 2016 22:14:24 +0100 From: One Thousand Gnomes To: Rob Herring Cc: Alan Cox , Greg Kroah-Hartman , Jiri Slaby , Peter Hurley , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 0/9] tty: tty_struct dependency clean-ups Message-ID: <20160911221424.2d56682a@lxorguk.ukuu.org.uk> In-Reply-To: <20160909223711.26238-1-robh@kernel.org> References: <20160909223711.26238-1-robh@kernel.org> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Sep 2016 17:37:01 -0500 Rob Herring wrote: > This patch series removes or prepares to remove some of the dependencies > on tty_struct within tty_port drivers. This will allow using tty_ports > directly for so called UART slave devices. You can create a tty_struct kernel side with the two tiny changes I posted before. Why do you want to do invasive tree wide changes when you can do simple ones ? > Next up after this are moving some functions to the tty_port ops. I've > got some WIP patches for some of that, but nothing ready to send out > quite yet. I think before this lot happens you need to decide where these structures belong. Termios and termios_locked for example could live in the tty_port as the physical tty is incapable of having multiple sets of terminal data at once. Really though this looks to me like *MASSIVE* churn for now purpose. Create a tty_struct kernel side, and use that, the needed patch is then tiny. so IMHO NAK Alan