From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Date: Sun, 11 Sep 2016 16:57:40 -0600 Message-ID: <20160911225740.GA32049@linux.intel.com> References: <20160826212934.GA11265@linux.intel.com> <20160829074116.GA16491@infradead.org> <20160829125741.cdnbb2uaditcmnw2@thunk.org> <20160909164808.GC18554@linux.intel.com> <20160910073012.GA5295@infradead.org> <20160910074228.GA23749@infradead.org> <20160911124741.GA746@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160911124741.GA746@infradead.org> Sender: owner-linux-mm@kvack.org To: Christoph Hellwig Cc: Matthew Wilcox , Ross Zwisler , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andrew Morton , "linux-nvdimm@ml01.01.org" , Dave Chinner , "linux-mm@kvack.org" , Andreas Dilger , Alexander Viro , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" List-Id: linux-nvdimm@lists.01.org On Sun, Sep 11, 2016 at 05:47:41AM -0700, Christoph Hellwig wrote: > On Sat, Sep 10, 2016 at 07:52:53AM +0000, Matthew Wilcox wrote: > > DAX code over to using iomap requires converting all of ext2 away from > > buffer_head; are you saying he's wrong? > > Not sure if he's really saying that, but it's wrong for sure. Just > to prove that I came up with a working ext2 iomap DAX implementation > in a few hours today. I'll take a stab at ext4 and the block device > as well and will post the updated series early next week - I'll need > to take care of a few high priority todo list items first. Yay! Sorry if I was unclear, I wasn't trying to say that we had to change all of ext2 over to using struct iomap. If we can (and apparently we can) just switch over the DAX interfaces, that's good enough to me. I understand that this will mean that we may have overlapping DAX paths for a while (an iomap version and a buffer_head version). I just wanted to figure out whether this overlap would need to be permanent - sounds like not, which is ideal. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755436AbcIKW5q (ORCPT ); Sun, 11 Sep 2016 18:57:46 -0400 Received: from mga05.intel.com ([192.55.52.43]:19083 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbcIKW5n (ORCPT ); Sun, 11 Sep 2016 18:57:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,319,1470726000"; d="scan'208";a="1048868712" Date: Sun, 11 Sep 2016 16:57:40 -0600 From: Ross Zwisler To: Christoph Hellwig Cc: Matthew Wilcox , Ross Zwisler , "Theodore Ts'o" , "linux-kernel@vger.kernel.org" , Andrew Morton , "linux-nvdimm@ml01.01.org" , Dave Chinner , "linux-mm@kvack.org" , Andreas Dilger , Alexander Viro , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" Subject: Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Message-ID: <20160911225740.GA32049@linux.intel.com> Mail-Followup-To: Ross Zwisler , Christoph Hellwig , Matthew Wilcox , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andrew Morton , "linux-nvdimm@ml01.01.org" , Dave Chinner , "linux-mm@kvack.org" , Andreas Dilger , Alexander Viro , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" References: <20160826212934.GA11265@linux.intel.com> <20160829074116.GA16491@infradead.org> <20160829125741.cdnbb2uaditcmnw2@thunk.org> <20160909164808.GC18554@linux.intel.com> <20160910073012.GA5295@infradead.org> <20160910074228.GA23749@infradead.org> <20160911124741.GA746@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160911124741.GA746@infradead.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 05:47:41AM -0700, Christoph Hellwig wrote: > On Sat, Sep 10, 2016 at 07:52:53AM +0000, Matthew Wilcox wrote: > > DAX code over to using iomap requires converting all of ext2 away from > > buffer_head; are you saying he's wrong? > > Not sure if he's really saying that, but it's wrong for sure. Just > to prove that I came up with a working ext2 iomap DAX implementation > in a few hours today. I'll take a stab at ext4 and the block device > as well and will post the updated series early next week - I'll need > to take care of a few high priority todo list items first. Yay! Sorry if I was unclear, I wasn't trying to say that we had to change all of ext2 over to using struct iomap. If we can (and apparently we can) just switch over the DAX interfaces, that's good enough to me. I understand that this will mean that we may have overlapping DAX paths for a while (an iomap version and a buffer_head version). I just wanted to figure out whether this overlap would need to be permanent - sounds like not, which is ideal.