From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbcILGLg (ORCPT ); Mon, 12 Sep 2016 02:11:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56032 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbcILGLd (ORCPT ); Mon, 12 Sep 2016 02:11:33 -0400 Date: Mon, 12 Sep 2016 08:11:38 +0200 From: Greg KH To: Guenter Roeck Cc: vadimp@mellanox.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, davem@davemloft.net, geert@linux-m68k.org, akpm@linux-foundation.org, kvalo@codeaurora.org, mchehab@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox systems platform Message-ID: <20160912061138.GA11230@kroah.com> References: <1473661798-112691-1-git-send-email-vadimp@mellanox.com> <4e3f6ebf-2c14-6872-6a74-35da891b66be@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e3f6ebf-2c14-6872-6a74-35da891b66be@roeck-us.net> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 10:34:27PM -0700, Guenter Roeck wrote: > > +static int mlxplat_lpc_config(struct mlxplat_priv *priv) > > +{ > > + struct pci_dev *pdev = NULL; > > + u16 dev_id; > > + int err; > > + > > + pdev = pci_get_bus_and_slot(MLXPLAT_CPLD_LPC_CTRL_IFC_BUS_ID, > > + PCI_DEVFN(MLXPLAT_CPLD_LPC_CTRL_IFC_SLOT_ID, > > + MLXPLAT_CPLD_LPC_CTRL_IFC_FUNC_ID)); > > + > > Kind of unusual way to initialize a PCI device. If this can't be implemented > as PCI driver, maybe it should be initialized using PCI quirks ? That's a _very old_ way of writing a pci driver, I thought we had gotten rid of all of that crud. This needs to be a "normal" PCI driver, no need for it to be a platform driver at all from what I can tell. thanks, greg k-h