From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: booti: fix the image runtime location
Date: Mon, 12 Sep 2016 17:18:53 +0800 [thread overview]
Message-ID: <20160912091850.GA23934@linux-7smt.suse> (raw)
In-Reply-To: <1473671278-23831-1-git-send-email-peng.fan@nxp.com>
On Mon, Sep 12, 2016 at 05:07:58PM +0800, Peng Fan wrote:
>We should not use "bi_dram[0].start + text_offset" as the image dst.
>The text_offset maybe 0 for some images, such as XEN. Then the dst
>is actually bi_dram[0].start, which maybe the location of spin table.
>
>Let's use "images->ep & ~(ih->text_offset)" as the dst address.
This patch maybe not that correct according to the doc from Linux kernel.
"
The Image must be placed text_offset bytes from a 2MB aligned base
address anywhere in usable system RAM and called there. The region
between the 2 MB aligned base address and the start of the image has no
special significance to the kernel, and may be used for other purposes.
"
Now I do not have a good idea that we may have a spin table in the start
of DRAM or even a small firmware.
Is it better to change gd->bd->bi_dram[0].start?
For example physical dram starts from 0x80000000, but 4K is reserved at the beginning.
So is it ok to change gd->bd->bi_dram[0].start to 0x80001000?
Thanks,
Peng.
>
>Signed-off-by: Peng Fan <peng.fan@nxp.com>
>Cc: Tom Rini <trini@konsulko.com>
>---
> cmd/booti.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/cmd/booti.c b/cmd/booti.c
>index 6c1c998..afc87e3 100644
>--- a/cmd/booti.c
>+++ b/cmd/booti.c
>@@ -54,7 +54,9 @@ static int booti_setup(bootm_headers_t *images)
> * If we are not at the correct run-time location, set the new
> * correct location and then move the image there.
> */
>- dst = gd->bd->bi_dram[0].start + le64_to_cpu(ih->text_offset);
>+ dst = images->ep & ~(ih->text_offset);
>+ if (dst < gd->bd->bi_dram[0].start)
>+ dst = gd->bd->bi_dram[0].start + le64_to_cpu(ih->text_offset);
>
> unmap_sysmem(ih);
>
>--
>2.6.2
>
next prev parent reply other threads:[~2016-09-12 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 9:07 [U-Boot] [PATCH] cmd: booti: fix the image runtime location Peng Fan
2016-09-12 9:18 ` Peng Fan [this message]
2016-09-12 12:04 ` Tom Rini
2016-09-13 6:02 ` Peng Fan
2016-09-13 11:19 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912091850.GA23934@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.