From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 4/4] tpm/tpm_crb: fix the over 80 characters checkpatch warring Date: Mon, 12 Sep 2016 12:30:20 +0300 Message-ID: <20160912093020.GE5094@intel.com> References: <1473635035-14443-1-git-send-email-tomas.winkler@intel.com> <1473635035-14443-5-git-send-email-tomas.winkler@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1473635035-14443-5-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Tomas Winkler Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Sep 12, 2016 at 02:03:55AM +0300, Tomas Winkler wrote: > Because of the line break in the debug print the chackpatch is > not silent on 80 characters limitation. > > The easiest fix is to straighten the lines, it's also more readable. > > WARNING: line over 80 characters > + FW_BUG "TPM2 ACPI table does not define a memory > resource\n"); > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_crb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > index 0c9989d0106e..6e9d1bca712f 100644 > --- a/drivers/char/tpm/tpm_crb.c > +++ b/drivers/char/tpm/tpm_crb.c > @@ -263,8 +263,7 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv, > acpi_dev_free_resource_list(&resources); > > if (resource_type(&io_res) != IORESOURCE_MEM) { > - dev_err(dev, > - FW_BUG "TPM2 ACPI table does not define a memory resource\n"); > + dev_err(dev, FW_BUG "TPM2 ACPI table does not define a memory resource\n"); > return -EINVAL; > } > > -- > 2.7.4 > ------------------------------------------------------------------------------