From: Zorro Lang <zlang@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: exit with status 2 if log dirtiness is unknown
Date: Mon, 12 Sep 2016 21:55:55 +0800 [thread overview]
Message-ID: <20160912135555.GE12847@dhcp12-143.nay.redhat.com> (raw)
In-Reply-To: <4c59d0b7-bf53-ca58-1bcf-b95d1c9c44dc@redhat.com>
On Mon, Sep 12, 2016 at 07:46:05AM -0500, Eric Sandeen wrote:
> This new case is mostly like the known dirty log case; the log
> is corrupt, dirtiness cannot be determined, and a mount/umount
> cycle or an xfs_repair -L is required.
>
> So exit with status 2 here as well.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/repair/phase2.c b/repair/phase2.c
> index e21ffa6..5964244 100644
> --- a/repair/phase2.c
> +++ b/repair/phase2.c
> @@ -79,10 +79,11 @@ zero_log(
> _("zero_log: cannot find log head/tail (xlog_find_tail=%d)\n"),
> error);
> if (!no_modify && !zap_log)
> - do_error(_(
> + do_warn(_(
> "ERROR: The log head and/or tail cannot be discovered. Attempt to mount the\n"
> "filesystem to replay the log or use the -L option to destroy the log and\n"
> "attempt a repair.\n"));
> + exit(2);
HaHa, I've talked about this problem with "Xiao Yang" in:
http://www.spinics.net/lists/fstests/msg03888.html
I talked him either change the _repair_scratch_fs function to check return
status 1, or change xfs_repair to make it return status 2. I don't know if
it's necessary to change the xfs_repair exit status. Is there some rules to
document that?
I'm trying to change the xfs_repair manpage:
http://www.spinics.net/lists/xfs/msg42346.html
Would you please help to check that? Any suggestions about that? I need to
change my patch if this patch will be merged.
Thanks,
Zorro
> } else {
> if (verbose) {
> do_warn(
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-09-12 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 12:46 [PATCH] xfs_repair: exit with status 2 if log dirtiness is unknown Eric Sandeen
2016-09-12 13:55 ` Zorro Lang [this message]
2016-09-13 16:01 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912135555.GE12847@dhcp12-143.nay.redhat.com \
--to=zlang@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.