From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758935AbcILOvy (ORCPT ); Mon, 12 Sep 2016 10:51:54 -0400 Received: from verein.lst.de ([213.95.11.211]:38788 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756816AbcILOvt (ORCPT ); Mon, 12 Sep 2016 10:51:49 -0400 Date: Mon, 12 Sep 2016 16:51:46 +0200 From: Christoph Hellwig To: Ingo Molnar Cc: Christoph Hellwig , sstabellini@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH] xen: consolidate swiotbl_xen dma_ops Message-ID: <20160912145146.GA27766@lst.de> References: <1473611708-25179-1-git-send-email-hch@lst.de> <20160912114539.GB7597@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912114539.GB7597@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 01:45:40PM +0200, Ingo Molnar wrote: > Please organize such initializers better! Something like this: > Makes it much easier to review such definitions. That's my personal preference, too. But this is just moving/consolidating code, so I don't plan to do fancy moves.