From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933305AbcILPPj (ORCPT ); Mon, 12 Sep 2016 11:15:39 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41735 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759530AbcILPPc (ORCPT ); Mon, 12 Sep 2016 11:15:32 -0400 Date: Mon, 12 Sep 2016 17:15:16 +0200 From: Andrew Lunn To: LABBE Corentin Cc: robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Message-ID: <20160912151516.GJ11400@lunn.ch> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> <20160909140413.GD30871@lunn.ch> <20160912150125.GA15570@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912150125.GA15570@Red> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hello > > Since the MDIO bus is a part of the sun8i-emac, does I really need > to create such a mdio node ? It is good practice. Part of the issue is that there are no written guidelines, so different drivers do different things. I'm trying to push all new drivers to have an MDIO node. > Anyway I try the following patch to solve your comments, but it > breaks the PHY finding(Could not attach to PHY). > --- a/drivers/net/ethernet/allwinner/sun8i-emac.c > +++ b/drivers/net/ethernet/allwinner/sun8i-emac.c > @@ -2122,7 +2122,7 @@ static int sun8i_emac_probe(struct platform_device *pdev) > return -EINVAL; > } > > - priv->phy_node = of_parse_phandle(node, "phy", 0); > + priv->phy_node = of_parse_phandle(node, "phy-handle", 0); > if (!priv->phy_node) { > netdev_err(ndev, "No associated PHY\n"); > return -ENODEV; > > > &crypto { > I don't see a change here for of_mdiobus_register(). You need to pass the mdio node. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Mon, 12 Sep 2016 17:15:16 +0200 Subject: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac In-Reply-To: <20160912150125.GA15570@Red> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> <20160909140413.GD30871@lunn.ch> <20160912150125.GA15570@Red> Message-ID: <20160912151516.GJ11400@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Hello > > Since the MDIO bus is a part of the sun8i-emac, does I really need > to create such a mdio node ? It is good practice. Part of the issue is that there are no written guidelines, so different drivers do different things. I'm trying to push all new drivers to have an MDIO node. > Anyway I try the following patch to solve your comments, but it > breaks the PHY finding(Could not attach to PHY). > --- a/drivers/net/ethernet/allwinner/sun8i-emac.c > +++ b/drivers/net/ethernet/allwinner/sun8i-emac.c > @@ -2122,7 +2122,7 @@ static int sun8i_emac_probe(struct platform_device *pdev) > return -EINVAL; > } > > - priv->phy_node = of_parse_phandle(node, "phy", 0); > + priv->phy_node = of_parse_phandle(node, "phy-handle", 0); > if (!priv->phy_node) { > netdev_err(ndev, "No associated PHY\n"); > return -ENODEV; > > > &crypto { > I don't see a change here for of_mdiobus_register(). You need to pass the mdio node. Andrew