From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: introduce & use i915_gem_object_{set, clear, is}_dirty()
Date: Mon, 12 Sep 2016 20:44:16 +0100 [thread overview]
Message-ID: <20160912194416.GA25084@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <57D6CE63.2090706@linux.intel.com>
On Mon, Sep 12, 2016 at 04:48:51PM +0100, Tvrtko Ursulin wrote:
> > * able to defer doing this until we know the object would be
> > * swapped, but there is no way to do that yet.
> > */
> >- i915_vma_move_to_active(from->engine[RCS].state, req, 0);
> >+ i915_vma_move_to_active(from_vma, req, 0);
> >+ i915_gem_object_set_dirty(from_vma->obj);
>
> Commit message should mention this.
No. This should not be here as we removed it because we always mark the
object as dirty when active on the GPU.
I don't see any improvement in this patch over mine, so what's the
reason for it? Certainly the lack of debug checks is odd.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-12 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 19:48 [PATCH] drm/i915: introduce & use i915_gem_object_{set, clear, is}_dirty() Dave Gordon
2016-09-09 20:49 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-09-12 15:48 ` [PATCH] " Tvrtko Ursulin
2016-09-12 19:44 ` Chris Wilson [this message]
2016-09-14 14:41 ` Dave Gordon
2016-09-14 14:48 ` [PATCH v3] " Dave Gordon
2016-09-14 15:20 ` ✗ Fi.CI.BAT: failure for drm/i915: introduce & use i915_gem_object_{set, clear, is}_dirty() (rev2) Patchwork
2016-09-15 7:20 ` ✗ Fi.CI.BAT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912194416.GA25084@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.