From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bjaEL-0002Ow-5I
	for qemu-devel@nongnu.org; Mon, 12 Sep 2016 19:01:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bjaEF-0004tr-5l
	for qemu-devel@nongnu.org; Mon, 12 Sep 2016 19:01:36 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bjaEE-0004ti-Vr
	for qemu-devel@nongnu.org; Mon, 12 Sep 2016 19:01:31 -0400
Received: by mail-wm0-f66.google.com with SMTP id b187so15682599wme.0
	for <qemu-devel@nongnu.org>; Mon, 12 Sep 2016 16:01:30 -0700 (PDT)
Date: Tue, 13 Sep 2016 01:00:28 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20160912230028.GO16305@toto>
References: <1473076452-19795-1-git-send-email-rabin.vincent@axis.com>
	<1473076452-19795-4-git-send-email-rabin.vincent@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1473076452-19795-4-git-send-email-rabin.vincent@axis.com>
Subject: Re: [Qemu-devel] [PATCH 4/9] tests: cris: remove check_time1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rabin Vincent <rabin.vincent@axis.com>
Cc: qemu-devel@nongnu.org, Rabin Vincent <rabinv@axis.com>

On Mon, Sep 05, 2016 at 01:54:07PM +0200, Rabin Vincent wrote:
> From: Rabin Vincent <rabinv@axis.com>
> 
> This test, borrowed from the GDB simulator test suite, checks that every
> syscall increments the time returned by gettimeofday() by exactly 1 ms.
> This is not guaranteed or even desirable on QEMU so remove this test.
> 
> Signed-off-by: Rabin Vincent <rabinv@axis.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> ---
>  tests/tcg/cris/Makefile      |  1 -
>  tests/tcg/cris/check_time1.c | 46 --------------------------------------------
>  2 files changed, 47 deletions(-)
>  delete mode 100644 tests/tcg/cris/check_time1.c
> 
> diff --git a/tests/tcg/cris/Makefile b/tests/tcg/cris/Makefile
> index f5230fc..14a9eb5 100644
> --- a/tests/tcg/cris/Makefile
> +++ b/tests/tcg/cris/Makefile
> @@ -114,7 +114,6 @@ TESTCASES += check_mmap1.ctst
>  TESTCASES += check_mmap2.ctst
>  TESTCASES += check_mmap3.ctst
>  TESTCASES += check_sigalrm.ctst
> -TESTCASES += check_time1.ctst
>  TESTCASES += check_time2.ctst
>  TESTCASES += check_settls1.ctst
>  
> diff --git a/tests/tcg/cris/check_time1.c b/tests/tcg/cris/check_time1.c
> deleted file mode 100644
> index 3fcf0e1..0000000
> --- a/tests/tcg/cris/check_time1.c
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -/* Basic time functionality test: check that milliseconds are
> -   incremented for each syscall (does not work on host).  */
> -#include <stdio.h>
> -#include <time.h>
> -#include <sys/time.h>
> -#include <string.h>
> -#include <stdlib.h>
> -
> -void err (const char *s)
> -{
> -  perror (s);
> -  abort ();
> -}
> -
> -int
> -main (void)
> -{
> -  struct timeval t_m = {0, 0};
> -  struct timezone t_z = {0, 0};
> -  struct timeval t_m1 = {0, 0};
> -  int i;
> -
> -  if (gettimeofday (&t_m, &t_z) != 0)
> -    err ("gettimeofday");
> -
> -  for (i = 1; i < 10000; i++)
> -    if (gettimeofday (&t_m1, NULL) != 0)
> -      err ("gettimeofday 1");
> -    else
> -      if (t_m1.tv_sec * 1000000 + t_m1.tv_usec
> -	  != (t_m.tv_sec * 1000000 + t_m.tv_usec + i * 1000))
> -	{
> -	  fprintf (stderr, "t0 (%ld, %ld), i %d, t1 (%ld, %ld)\n",
> -		   t_m.tv_sec, t_m.tv_usec, i, t_m1.tv_sec, t_m1.tv_usec);
> -	  abort ();
> -	}
> -
> -  if (time (NULL) != t_m1.tv_sec)
> -    {
> -      fprintf (stderr, "time != gettod\n");
> -      abort ();
> -    }
> -
> -  printf ("pass\n");
> -  exit (0);
> -}
> -- 
> 2.1.4
>