From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757035AbcIMIuc (ORCPT ); Tue, 13 Sep 2016 04:50:32 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36630 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755902AbcIMIu2 (ORCPT ); Tue, 13 Sep 2016 04:50:28 -0400 Date: Tue, 13 Sep 2016 09:52:25 +0100 From: Lee Jones To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , Florian Lobmaier , Laxman Dewangan Subject: Re: [PATCH 2/6] mfd: as3722: convert MFD_AS3722 from bool to tristate Message-ID: <20160913085225.GB24465@dell> References: <20160912144054.27522-1-paul.gortmaker@windriver.com> <20160912144054.27522-3-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160912144054.27522-3-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Sep 2016, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_AS3722 > drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC" > > ...meaning that it currently is not being built as a module by anyone. > > In response to an earlier patch set suggesting removal of the unused > modular code, Laxman suggested that this driver be instead moved to > tristate. > > We do that here, and confirm it can build and modpost as a tristate. > However there remains to be runtime testing in order to ensure this > change is 100% functional for "=m". > > Cc: Samuel Ortiz > Cc: Lee Jones > Cc: Florian Lobmaier > Cc: Laxman Dewangan > Signed-off-by: Paul Gortmaker > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 9ac9f6250ba8..9a529bf06eed 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -50,7 +50,7 @@ config MFD_AS3711 > Support for the AS3711 PMIC from AMS > > config MFD_AS3722 > - bool "ams AS3722 Power Management IC" > + tristate "ams AS3722 Power Management IC" > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog