[PATCH] kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS

[PATCH] kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS

[André Draszik]

Various recipes depend on the kernel's do_shared_workdir
task, a quick grep suggests all external kernel modules
(via module.bbclass), but also perf, and potentially any
additional headers as outlined in linux-libc-headers.inc
are affected.

Having do_shared_workdir in SRCTREECOVEREDTASKS means this
task is removed when externalsrc is enabled, making all
those recipes fail as the task they depend on,
virtual/kernel:do_shared_workdir, doesn't exist.

Remove do_shared_workdir from SRCTREECOVEREDTASKS so that
all those recipes work even if externalsrc is activated.

According to the comment in here, the reason for
do_shared_workdir to be removed as a task is because it
modifies the source tree, but that doesn't seem to be
case.

Signed-off-by: André Draszik <git@andred.net>
---
 meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 82b9210..53659f2 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -1,5 +1,5 @@
 # remove tasks that modify the source tree in case externalsrc is inherited
-SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch do_unpack do_patch"
+SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
 
 # returns local (absolute) path names for all valid patches in the
 # src_uri
-- 
2.9.3

Re: [PATCH] kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS

[André Draszik]

Ignore this. This doesn't yet work as I intended I think.

On Di, 2016-09-13 at 10:07 +0100, André Draszik wrote:
> Various recipes depend on the kernel's do_shared_workdir
> task, a quick grep suggests all external kernel modules
> (via module.bbclass), but also perf, and potentially any
> additional headers as outlined in linux-libc-headers.inc
> are affected.
> 
> Having do_shared_workdir in SRCTREECOVEREDTASKS means this
> task is removed when externalsrc is enabled, making all
> those recipes fail as the task they depend on,
> virtual/kernel:do_shared_workdir, doesn't exist.
> 
> Remove do_shared_workdir from SRCTREECOVEREDTASKS so that
> all those recipes work even if externalsrc is activated.
> 
> According to the comment in here, the reason for
> do_shared_workdir to be removed as a task is because it
> modifies the source tree, but that doesn't seem to be
> case.
> 
> Signed-off-by: André Draszik <git@andred.net>
> ---
>  meta/classes/kernel-yocto.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-
> yocto.bbclass
> index 82b9210..53659f2 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -1,5 +1,5 @@
>  # remove tasks that modify the source tree in case externalsrc is
> inherited
> -SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches
> do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch
> do_unpack do_patch"
> +SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches
> do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
>  
>  # returns local (absolute) path names for all valid patches in the
>  # src_uri

Re: [PATCH] kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS

[André Draszik]

Please unignore this patch :-) The patch does what I intended.

Sorry for the noise.

On Di, 2016-09-13 at 12:09 +0100, André Draszik wrote:
> Ignore this. This doesn't yet work as I intended I think.
> 
> On Di, 2016-09-13 at 10:07 +0100, André Draszik wrote:
> > 
> > Various recipes depend on the kernel's do_shared_workdir
> > task, a quick grep suggests all external kernel modules
> > (via module.bbclass), but also perf, and potentially any
> > additional headers as outlined in linux-libc-headers.inc
> > are affected.
> > 
> > Having do_shared_workdir in SRCTREECOVEREDTASKS means this
> > task is removed when externalsrc is enabled, making all
> > those recipes fail as the task they depend on,
> > virtual/kernel:do_shared_workdir, doesn't exist.
> > 
> > Remove do_shared_workdir from SRCTREECOVEREDTASKS so that
> > all those recipes work even if externalsrc is activated.
> > 
> > According to the comment in here, the reason for
> > do_shared_workdir to be removed as a task is because it
> > modifies the source tree, but that doesn't seem to be
> > case.
> > 
> > Signed-off-by: André Draszik <git@andred.net>
> > ---
> >  meta/classes/kernel-yocto.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-
> > yocto.bbclass
> > index 82b9210..53659f2 100644
> > --- a/meta/classes/kernel-yocto.bbclass
> > +++ b/meta/classes/kernel-yocto.bbclass
> > @@ -1,5 +1,5 @@
> >  # remove tasks that modify the source tree in case externalsrc is
> > inherited
> > -SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches
> > do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch
> > do_unpack do_patch"
> > +SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches
> > do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
> >  
> >  # returns local (absolute) path names for all valid patches in the
> >  # src_uri