All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/2] Detect and reject new ad-hoc CONFIG options
Date: Tue, 13 Sep 2016 09:16:28 -0400	[thread overview]
Message-ID: <20160913131628.GB8156@bill-the-cat> (raw)
In-Reply-To: <1473744002-16018-1-git-send-email-sjg@chromium.org>

On Mon, Sep 12, 2016 at 11:20:00PM -0600, Simon Glass wrote:

> Despite the availability of Kconfig, the number of ad-hoc CONFIG options in
> U-Boot is still at over 8000.
> 
> In February 2015 (commit 741e58e0) there were around 8387 ad-hoc CONFIGs.
> As of this patch there are about 8336, only a little fewer.
> 
> One problem is that new ones are still being added, admittedly at a slower
> rate. This series adds a Makefile check to detect that and produce a build
> error. This provides immediate feedback that new CONFIG options should go in
> Kconfig.
> 
> Changes in v2:
> - Rebase to mainline
> - Fix scripts so that there are no errors
> - Add the 'build-whitelist.sh' script to the tree
> 
> Simon Glass (2):
>   Kconfig: Add a whitelist of ad-hoc CONFIG options
>   Makefile: Give a build error if ad-hoc CONFIG options are added

OK, this is still a little fragile.  When I do:
./tools/buildman/buildman -b master --force-build --step 0 \
 -SCdvel 'avr32|nds32|bfin|m68k|microblaze|or32|sh4|sparc|mips|mips64|xtensa'

vs kconfig-working2 I'm seeing a bunch of failures:
+(M5475GFE) make[1]: *** [no_new_adhoc_configs_check] Error 1
+(M5475GFE) make: *** [sub-make] Error 2

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160913/10967c80/attachment.sig>

  parent reply	other threads:[~2016-09-13 13:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13  5:20 [U-Boot] [PATCH v2 0/2] Detect and reject new ad-hoc CONFIG options Simon Glass
2016-09-13  5:20 ` [U-Boot] [PATCH v2 1/2] Kconfig: Add a whitelist of " Simon Glass
2016-09-13  5:20 ` [U-Boot] [PATCH v2 2/2] Makefile: Give a build error if ad-hoc CONFIG options are added Simon Glass
2016-09-13 13:16 ` Tom Rini [this message]
2016-09-13 13:35   ` [U-Boot] [PATCH v2 0/2] Detect and reject new ad-hoc CONFIG options Simon Glass
2016-09-13 13:49     ` Tom Rini
2016-09-13 18:38       ` Simon Glass
2016-09-14 19:06         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160913131628.GB8156@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.