From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758297AbcIMNdK (ORCPT ); Tue, 13 Sep 2016 09:33:10 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33715 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753069AbcIMNdG (ORCPT ); Tue, 13 Sep 2016 09:33:06 -0400 Date: Tue, 13 Sep 2016 15:33:01 +0200 From: LABBE Corentin To: Andrew Lunn Cc: robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver Message-ID: <20160913133301.GB31990@Red> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-2-git-send-email-clabbe.montjoie@gmail.com> <20160909141527.GE30871@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160909141527.GE30871@lunn.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote: > Hi Corentin > > > +static int sun8i_emac_mdio_register(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = mdiobus_alloc(); > > You can use devm_mdiobus_alloc() which will simplify your error > handling and unregister code. > > Andrew Hello Since the mdio bus is allocated on ndev/open, it need to be removed when ndev/stop is called. So devm_mdiobus_alloc cannot be used. Regards Corentin Labbe From mboxrd@z Thu Jan 1 00:00:00 1970 From: LABBE Corentin Subject: Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver Date: Tue, 13 Sep 2016 15:33:01 +0200 Message-ID: <20160913133301.GB31990@Red> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-2-git-send-email-clabbe.montjoie@gmail.com> <20160909141527.GE30871@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Return-path: Content-Disposition: inline In-Reply-To: <20160909141527.GE30871-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote: > Hi Corentin > > > +static int sun8i_emac_mdio_register(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = mdiobus_alloc(); > > You can use devm_mdiobus_alloc() which will simplify your error > handling and unregister code. > > Andrew Hello Since the mdio bus is allocated on ndev/open, it need to be removed when ndev/stop is called. So devm_mdiobus_alloc cannot be used. Regards Corentin Labbe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: clabbe.montjoie@gmail.com (LABBE Corentin) Date: Tue, 13 Sep 2016 15:33:01 +0200 Subject: [PATCH v3 1/9] ethernet: add sun8i-emac driver In-Reply-To: <20160909141527.GE30871@lunn.ch> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-2-git-send-email-clabbe.montjoie@gmail.com> <20160909141527.GE30871@lunn.ch> Message-ID: <20160913133301.GB31990@Red> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote: > Hi Corentin > > > +static int sun8i_emac_mdio_register(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = mdiobus_alloc(); > > You can use devm_mdiobus_alloc() which will simplify your error > handling and unregister code. > > Andrew Hello Since the mdio bus is allocated on ndev/open, it need to be removed when ndev/stop is called. So devm_mdiobus_alloc cannot be used. Regards Corentin Labbe