From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33960)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1bjpx1-0001gS-SU
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:48:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1bjpww-0001k3-7G
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:48:46 -0400
Date: Tue, 13 Sep 2016 16:48:29 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20160913154829.GD5677@stefanha-x1.localdomain>
References: <20160826091643.15841-1-fullmanet@gmail.com>
	<20160826091643.15841-3-fullmanet@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="YToU2i3Vx8H2dn7O"
Content-Disposition: inline
In-Reply-To: <20160826091643.15841-3-fullmanet@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/7] qemu-img: add iflag and oflag
 options to dd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Reda Sallahi <fullmanet@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Fam Zheng <famz@redhat.com>


--YToU2i3Vx8H2dn7O
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 26, 2016 at 11:16:38AM +0200, Reda Sallahi wrote:
> This adds the iflag and oflag options which defines the list of flags used
> for reading and writing respectively. The list is comma-separated.
>=20
> The iflag option supports direct, dsync, sync, count_bytes and skip_bytes
> and oflag supports direct, dsync, sync and seek_bytes. They are similar to
> their counterparts on GNU dd(1).
>=20
> Two tests were added to test iflag and oflag.
>=20
> Signed-off-by: Reda Sallahi <fullmanet@gmail.com>
> ---
>  qemu-img-cmds.hx           |   4 +-
>  qemu-img.c                 | 172 +++++++++++++++++++++++++++++++++++++++=
------
>  qemu-img.texi              |  32 +++++++--
>  tests/qemu-iotests/163     | 103 +++++++++++++++++++++++++++
>  tests/qemu-iotests/163.out | 135 +++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/164     | 100 ++++++++++++++++++++++++++
>  tests/qemu-iotests/164.out |  75 ++++++++++++++++++++
>  tests/qemu-iotests/group   |   2 +
>  8 files changed, 595 insertions(+), 28 deletions(-)
>  create mode 100755 tests/qemu-iotests/163
>  create mode 100644 tests/qemu-iotests/163.out
>  create mode 100755 tests/qemu-iotests/164
>  create mode 100644 tests/qemu-iotests/164.out

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--YToU2i3Vx8H2dn7O
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJX2B/NAAoJEJykq7OBq3PIKRQH/iXmrEfYM//Y3YNqSl2QNXe0
kpfHqHB5kwQZ9o65WIqTHJJaQzS06vEFEKiCeki0efO8P+Mk1CheajWQm5D7LMaL
ZsiyN0jQCu0c2CPspVRA0VIpL6fjMRlvhCPND2jlIpc4m+mjJGrhLKZcBnofGhYK
i1mn4KsoFBHNqCjWasKGkmRESL9tu3TCYc1z0JFMr5ixSc6u6b8Gu2zsGua5NHdb
iU9i/szj5iHYJVc2NQ6dpQ4EOHJSWqKY43RHJgCpYrg8/1WDUOqTSPOBBeWRdvVv
JJG3E8JZoXFXuvIUW25MIcBpUNLsJeet4MP2ijKRiuHihxlRW+HorCQzqNpthX8=
=iepc
-----END PGP SIGNATURE-----

--YToU2i3Vx8H2dn7O--