From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] net/vhost: Add function to retreive the
 'vid' for a given port id
Date: Wed, 14 Sep 2016 12:43:29 +0800
Message-ID: <20160914044329.GX23158@yliu-dev.sh.intel.com>
References: <1473774463-26966-1-git-send-email-ciara.loftus@intel.com>
 <28342659.xFrdpVFeBf@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ciara Loftus <ciara.loftus@intel.com>, dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 921C67F14
 for <dev@dpdk.org>; Wed, 14 Sep 2016 06:43:02 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <28342659.xFrdpVFeBf@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Sep 13, 2016 at 05:10:09PM +0200, Thomas Monjalon wrote:
> 2016-09-13 14:47, Ciara Loftus:
> > In some cases when using the vHost PMD, certain vHost library functions
> > may still need to be accessed. One such example is the
> > rte_vhost_get_queue_num function which returns the number of virtqueues
> > reported by the guest - information which is not exposed by the PMD.
> > 
> > This commit introduces a new rte_eth_vhost function that returns the
> > 'vid' associated with a given port id. This allows the PMD user to call
> > vHost library functions which require the 'vid' value.
> 
> I think we should not add any API to the PMDs.

In general, I agree with you.

> Maybe you are looking for a generic API in ethdev.

But maybe it's a bit hard to define a "right" generic API here. For this
case, the generic API I can think of could be:

- an API to get queue num, like rte_eth_get_queue_enabled_num
  I barely know NIC pmd drivers, but I doubt it's useful/meaningful for them.

- an API to get a PMD driver private (or specific) data.
  For vhost-pmd, it's vid. Again, I don't know what it could be for other nic
  drivers.

  This one may be a better option here, because it expose a key field to
  the application, vid, with which the application can invoke more vhost
  APIs. And apparently, it's not feasible to try to define a generic API
  for some (if not each) vhost APIs.
  

Or, better ideas?

	--yliu