All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi
Date: Wed, 14 Sep 2016 10:54:56 +0200	[thread overview]
Message-ID: <20160914085456.GD10233@verge.net.au> (raw)
In-Reply-To: <20160913125825.GA3510@katana>

On Tue, Sep 13, 2016 at 02:58:25PM +0200, Wolfram Sang wrote:
> On Tue, Sep 13, 2016 at 02:48:26PM +0200, Ulf Hansson wrote:
> > On 13 September 2016 at 12:56, Simon Horman <horms+renesas@verge.net.au> wrote:
> > >
> > > Hi,
> > >
> > > this series is based on work by Ai Kyuse to add UHS-I SDR-104 support for
> > > sh_mobile_sdhi. It builds on work by Shinobu Uehara, Rob Taylor, William
> > > Towle and Ian Molton, Ben Hutchings, Wolfram Sang and others to add UHS-I
> > > SDR-50 support to the same driver.
> > >
> > > It is based on a merge of the next branches of the mmc tree.
> > >
> > > To aid review the following git branch is provided:
> > > * https:://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/sdr104-driver-v7
> > >
> > > Overview of changes since v6:
> > > * Address review by Ulf
> > >   - Detailed in per-patch changelogs
> > > * Move integration (arm/arm64 dt) patches to separate patchset
> > >
> > > Please see http://elinux.org/Tests:SD-SDHI-SDR104 for indicative tests
> > > results.
> > >
> > >
> > > Ai Kyuse (3):
> > >   mmc: tmio: enhance illegal sequence handling
> > >   mmc: tmio: Add hw reset support
> > >   mmc: tmio: Add tuning support
> > >
> > > Simon Horman (3):
> > >   mmc: core: Add helper to see if a host can be retuned
> > >   mmc: tmio: document mandatory and optional callbacks
> > >   mmc: sh_mobile_sdhi: Add tuning support
> > >
> > >  drivers/mmc/host/sh_mobile_sdhi.c | 265 +++++++++++++++++++++++++++++++++++++-
> > >  drivers/mmc/host/tmio_mmc.h       |  18 ++-
> > >  drivers/mmc/host/tmio_mmc_pio.c   |  87 ++++++++++++-
> > >  include/linux/mmc/host.h          |   5 +
> > >  4 files changed, 367 insertions(+), 8 deletions(-)
> > >
> > > --
> > > 2.7.0.rc3.207.g0ac5344
> > >
> > 
> > This looks good to me, although I would like to get an ack from
> > Wolfram before I queue this up.
> 
> I'll test today or tomorrow. Same for the r7s72100 patches.

Thanks!

I found a logic error in the last patch of the series,
I proposed a fix in a sub-thread for that patch.

If you could use my proposed one-line fix when testing that would be great.

  reply	other threads:[~2016-09-14  8:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 10:56 [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Simon Horman
2016-09-13 10:56 ` [PATCH v7 1/6] mmc: core: Add helper to see if a host can be retuned Simon Horman
2016-09-13 10:56 ` [PATCH v7 2/6] mmc: tmio: enhance illegal sequence handling Simon Horman
2016-09-13 10:56 ` [PATCH v7 3/6] mmc: tmio: document mandatory and optional callbacks Simon Horman
2016-09-13 10:56 ` [PATCH v7 4/6] mmc: tmio: Add hw reset support Simon Horman
2016-09-13 10:56 ` [PATCH v7 5/6] mmc: tmio: Add tuning support Simon Horman
2016-09-13 10:56 ` [PATCH v7 6/6] mmc: sh_mobile_sdhi: " Simon Horman
2016-09-14  8:53   ` Simon Horman
2016-09-13 12:48 ` [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Ulf Hansson
2016-09-13 12:58   ` Wolfram Sang
2016-09-14  8:54     ` Simon Horman [this message]
2016-09-14 16:04   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914085456.GD10233@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.