From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBJh-0003u8-2d for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:37:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkBJf-0007PK-Qx for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:37:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBJf-0007P6-L8 for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:37:35 -0400 Date: Wed, 14 Sep 2016 15:37:32 +0100 From: Stefan Hajnoczi Message-ID: <20160914143732.GF16438@stefanha-x1.localdomain> References: <147310178240.10840.14758930096407696981.stgit@fimbulvetr.bsc.es> <147310180392.10840.12864372901014347462.stgit@fimbulvetr.bsc.es> <20160906044154-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/aVve/J9H4Wl5yVO" Content-Disposition: inline In-Reply-To: <20160906044154-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [PATCH v2 4/6] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: =?iso-8859-1?Q?Llu=EDs?= Vilanova , qemu-devel@nongnu.org, Daniel P Berrange , Luiz Capitulino , Eric Blake , Marcel Apfelbaum --/aVve/J9H4Wl5yVO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 06, 2016 at 04:43:00AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 05, 2016 at 08:56:44PM +0200, Llu=EDs Vilanova wrote: > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > > index 929ec2f..8973f57 100644 > > --- a/include/hw/pci/pci.h > > +++ b/include/hw/pci/pci.h > > @@ -80,6 +80,8 @@ > > #define PCI_DEVICE_ID_VIRTIO_RNG 0x1005 > > #define PCI_DEVICE_ID_VIRTIO_9P 0x1009 > > =20 > > +#define PCI_DEVICE_ID_HYPERTRACE 0x10f0 > > + > > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > #define PCI_DEVICE_ID_REDHAT_BRIDGE 0x0001 > > #define PCI_DEVICE_ID_REDHAT_SERIAL 0x0002 >=20 >=20 > There's no need to add IDs to this header. > We should probably drop the ones we currently have in pci.h, too. Defining the PCI IDs in public headers gives libqos test cases access to them. If they are scoped to only be available in device emulation code then the test cases need to duplicate them, which is undesirable IMO. Stefan --/aVve/J9H4Wl5yVO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX2WCsAAoJEJykq7OBq3PI5Q0H/1VbUy/urLMlqbNtyfcfGGiU PvTgJ1Ck3RpobV7eRdcwY810H9bzFBF04FoNcciKSIT9IWpQkS57ghyjlufoc1Tw BAjj5gIJHxU9b3zDqlr9yvwLUl9oOu5qaHs8sAZJuEf6NCoQ3SsDZ2ss1wCqw5ji LJx7S0WX+4+M7Dw9gEf+jm55xYeGBkXslfNpZRJvuOsWvBkNsqSxaEaAbdWgALHJ t4FrRZWTKuiIhkK5oi1rDKgN42NmPkgYdSrfoQXH4p3W3pHS7o+0bdY7BW964/6A SqnTIuo/0lue1pm0WwQq5nmND21pP8/P0qZ4pSM/e5G1KCtXRaWFj73aOcysoaA= =N0l8 -----END PGP SIGNATURE----- --/aVve/J9H4Wl5yVO--